Alon Bar-Lev has posted comments on this change. Change subject: notifier: move to the new service infrastructure ......................................................................
Patch Set 4: Verified I found that there was duplication of validation within java code and shell... so we are feature complete now. I did not test this deeply as I have no clue of what notifier is doing, nor that the code looks sane. For example the smtp usage is totally wrong. I just hope I left it in better shape than it was. -- To view, visit http://gerrit.ovirt.org/14378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2aadeca8b3017dad4107939c7c624ef020347b94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
