Sandro Bonazzola has posted comments on this change.
Change subject: packaging - starting ovirt-engine only after yum rollback
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 1229: checkRunningTasks()
Line 1230: # If something went wrong, restart DB
services and the engine
Line 1231: except:
Line 1232: runFunc([[startDbRelatedServices,
etlService, notificationService]], MSG_INFO_START_DB)
Line 1233: runFunc(startEngineService,
MSG_INFO_START_ENGINE % engineService)
Here we're just restarting the services we stopped restoring the previous
state. Not restarting the services will lead to having an incomplete rollback.
This patch was intended just for fixing the rollback sequence without changing
the behavior of the script.
Line 1234: raise
Line 1235: else:
Line 1236: # This means that user chose not to stop
ovirt-engine
Line 1237: logging.debug("exiting gracefully")
Line 1292: raise
Line 1293:
Line 1294: finally:
Line 1295: # start engine after the rollback
Line 1296: runFunc([startEngine], MSG_INFO_START_ENGINE % engineService)
I would prefer not changing the original code, as you said, we are going to
kill this code anyway
Line 1297:
Line 1298: # Print log location on success
Line 1299: addAdditionalMessages(etlService.isServiceAvailable())
Line 1300: print "\n%s\n" % MSG_INFO_UPGRADE_OK
--
To view, visit http://gerrit.ovirt.org/14387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8160293d45361534dfda6c6aa3870e72368d10b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
