[Engine-patches] Change in ovirt-engine[master]: findbugs: Fix fingbugs error in SanTargetModel class

[tnisan]

Tal Nisan has uploaded a new change for review.

Change subject: findbugs: Fix fingbugs error in SanTargetModel class
......................................................................

findbugs: Fix fingbugs error in SanTargetModel class

Change-Id: Ib4a4fd6bb5b2743d0dc939751d31f5247de6fc7f
Signed-off-by: Tal Nisan <tni...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java
2 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/14456/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
index f8b7e61..770ff14 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
@@ -295,7 +295,7 @@
     {
         super.eventRaised(ev, sender, args);
 
-        if (ev.matchesDefinition(SanTargetModel.LoggedInEventDefinition))
+        if (ev.matchesDefinition(SanTargetModel.loggedInEventDefinition))
         {
             SanTargetModel_LoggedIn(sender, args);
         }
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java
index e93e741..bcb5fa1 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java
@@ -1,5 +1,7 @@
 package org.ovirt.engine.ui.uicommonweb.models.storage;
 
+import java.util.List;
+
 import org.ovirt.engine.core.compat.StringHelper;
 import org.ovirt.engine.ui.uicommonweb.UICommand;
 import org.ovirt.engine.ui.uicommonweb.models.EntityModel;
@@ -9,13 +11,11 @@
 import org.ovirt.engine.ui.uicompat.EventDefinition;
 import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
 
-import java.util.List;
-
 @SuppressWarnings("unused")
 public class SanTargetModel extends EntityModel
 {
 
-    public static EventDefinition LoggedInEventDefinition;
+    final static EventDefinition loggedInEventDefinition;
     private Event privateLoggedInEvent;
 
     public Event getLoggedInEvent()
@@ -139,17 +139,17 @@
 
     static
     {
-        LoggedInEventDefinition = new EventDefinition("LoggedIn", 
SanTargetModel.class); //$NON-NLS-1$
+        loggedInEventDefinition = new EventDefinition("LoggedIn", 
SanTargetModel.class); //$NON-NLS-1$
     }
 
     public SanTargetModel()
     {
-        setLoggedInEvent(new Event(LoggedInEventDefinition));
+        setLoggedInEvent(new Event(loggedInEventDefinition));
         setLoginCommand(new UICommand("Login", this)); //$NON-NLS-1$
         setLunsList(new ListModel());
     }
 
-    private void Login()
+    private void login()
     {
         getLoggedInEvent().raise(this, EventArgs.Empty);
     }
@@ -161,7 +161,7 @@
 
         if (command == getLoginCommand())
         {
-            Login();
+            login();
         }
     }
 }


--
To view, visit http://gerrit.ovirt.org/14456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4a4fd6bb5b2743d0dc939751d31f5247de6fc7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches