Allon Mureinik has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 11: Looks good to me, but someone else must approve
(2 inline comments)
@Alissa:
1. Please see my inli
Allon Mureinik has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 9: (2 inline comments)
Answered inline to Alissa's responses.
Allon Mureinik has posted comments on this change.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
..
Patch Set 4: Looks good to me, approved
@Liron - please rebase so this is not on top of an a
Allon Mureinik has posted comments on this change.
Change subject: core: log using INFO logging level rather than ERROR
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
...
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: Persist the changes from console popup
..
Patch Set 1:
The same mechanism is used than for other options stored on client side, e.g.:
- conn
Allon Mureinik has posted comments on this change.
Change subject: core: mark default locking pairs as Deprecated
..
Patch Set 1: Looks good to me, but someone else must approve
Sounds like a good idea to me.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: AddVmFromSnapshot - avoid early end method run
..
Patch Set 2:
@Liron - now that this patch is verified, please rebase it so I can merge.
--
To view, vis
Eli Mesika has posted comments on this change.
Change subject: core: taskcleaner.sh should treat null argument as -h
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13319
To unsubscribe, visit http://gerrit.o
Eli Mesika has uploaded a new change for review.
Change subject: core: taskcleaner.sh should treat null argument as -h
..
core: taskcleaner.sh should treat null argument as -h
Adding a check fot the USERNAME which is mandatory.
Maor Lipchuk has posted comments on this change.
Change subject: core: prevent rollback on VmReplicateDiskFinish success
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13306
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: core: LiveMigrateDisk - check isRunningOrPaused VMStatus
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13242
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 3: (1 inline comment)
File packaging/fedo
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 11: Verified
added more unitests and validations for empty host and empty data center
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 3:
Michael,
You are CC as there is special setting for the entire application just because
"
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 10:
and unitests for those use cases...
--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe,
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 10: Verified
Added backend verification for empty host and data center ids.
--
To view, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updating apache templates with explicit values
..
Patch Set 1: (4 inline comments)
File packaging/
Daniel Erez has posted comments on this change.
Change subject: webadmin: show quota tab only for correct DCs
..
Patch Set 1: (2 inline comments)
File
frontend/webadmin/modu
Daniel Erez has posted comments on this change.
Change subject: core: Rename methods to start with small letter
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Alex Lourie has posted comments on this change.
Change subject: packaging: Updating apache templates with explicit values
..
Patch Set 1:
Still verifying
--
To view, visit http://gerrit.ovirt.org/13318
To unsubscribe, visit ht
Alissa Bonas has posted comments on this change.
Change subject: core: Rename methods to start with small letter
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13317
To unsubscribe, visit http://gerrit.ovirt
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updating apache templates with explicit values
..
packaging: Updating apache templates with explicit values
Currently we use an ovirt-engine-proxy temp
Alissa Bonas has uploaded a new change for review.
Change subject: core: Rename methods to start with small letter
..
core: Rename methods to start with small letter
Rename private methods in StorageListModel to start with small
Alon Bar-Lev has posted comments on this change.
Change subject: core: support overriding environment
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13316
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: core: support overriding environment
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13315
To unsubscribe, visit ht
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: support overriding environment
..
core: support overriding environment
Useful for distro settings.
Change-Id: I933373b31c3f2e1b8f7a8a5624b47eaa8b0
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: support overriding environment
..
core: support overriding environment
Useful for distro settings.
Change-Id: Ib619c87ac41374ef5007beb3d6de068fcfeb3ff5
Si
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: support overriding environment
..
core: support overriding environment
Useful for distro settings.
Change-Id: I933373b31c3f2e1b8f7a8a5624b47eaa8b0a70e4
Si
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use simplified template when hadnling
ovirt-engine-proxy.conf.in
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13313
To unsubscri
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: remove unused lock directory
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13314
To unsubscribe, visit http://gerrit.ovirt.org/set
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: remove unused lock directory
..
packaging: remove unused lock directory
Change-Id: I8610a41c64d069a283e6ff3a04fa2cf827dd5540
Signed-off-by: Alon Bar-L
Arik Hadas has posted comments on this change.
Change subject: core: mark default locking pairs as Deprecated
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13312
To unsubscribe, visit http://gerrit.ovirt.or
Arik Hadas has posted comments on this change.
Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Arik Hadas has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery
..
Patch Set 2: (1 inline comment)
@Arik - see inline
@Daniel - who can make this call?
..
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
restapi: add cpu-mode enumerable values to /capabilities #915042
https://bugzill
Michael Pasternak has posted comments on this change.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
restapi: add cpu-mode enumerable values to /capabilities #915042
https://bugzill
Michael Pasternak has posted comments on this change.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13308
To unsubscribe, vis
Michael Pasternak has posted comments on this change.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13308
T
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: use simplified template when hadnling
ovirt-engine-proxy.conf.in
..
packaging: use simplified template when hadnling ovirt-engine-proxy.conf.in
Chang
Arik Hadas has uploaded a new change for review.
Change subject: core: mark default locking pairs as Deprecated
..
core: mark default locking pairs as Deprecated
LockMessagesMatchUtil contains several pairs of locking group and
Arik Hadas has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/ma
Liron Ar has abandoned this change.
Change subject: [wip] core: rename MoveOrCopyImageGroup to CopyImageGroup
..
Patch Set 1: Abandoned
This change was squashed into this change: http://gerrit.ovirt.org/#/c/13042/
as requested
Liron Ar has posted comments on this change.
Change subject: [wip] core: rename MoveOrCopyImageGroup to CopyImageGroup
..
Patch Set 1:
This change was squashed into this change: http://gerrit.ovirt.org/#/c/13042/
as requested,
Liron Ar has posted comments on this change.
Change subject: [wip] core: rename MoveOrCopyImageGroup to CopyImageGroup
..
Patch Set 1: (2 inline comments)
File
backend/manag
Liron Ar has uploaded a new change for review.
Change subject: core: log using INFO logging level rather than ERROR
..
core: log using INFO logging level rather than ERROR
When EventQueueMonitor cancels events, print the log usi
Doron Fediuck has posted comments on this change.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
Patch Set 1: Looks good to me, but someone else must approve
Thanks for the contribution!
--
Allon Mureinik has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/sr
Liron Ar has posted comments on this change.
Change subject: [wip] core: refactor MoveOrCopy/RemoveImage commands and
parameters
..
Patch Set 2: (3 inline comments)
File
ba
Liron Ar has posted comments on this change.
Change subject: [wip] core: move image group command
..
Patch Set 1: (4 inline comments)
File
backend/manager/modules/bll/src/ma
Doron Fediuck has posted comments on this change.
Change subject: core: Move scheduler to modules
..
Patch Set 2:
Gilad- please make sure to sync with this change.
--
To view, visit http://gerrit.ovirt.org/13224
To unsubscribe
Liron Ar has posted comments on this change.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
..
Patch Set 4:
rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/12452
To unsubsc
Liron Ar has abandoned this change.
Change subject: a
..
Patch Set 1: Abandoned
dummy commit
--
To view, visit http://gerrit.ovirt.org/13310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
G
Liron Ar has uploaded a new change for review.
Change subject: a
..
a
Change-Id: I40671e092a6c053f941c4508d684f691c32e2b91
Signed-off-by: Liron Aravot
---
A a.txt
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
restapi: add cpu-mode enumerable values to /capabilities #915042
https://bugzilla.redhat
Arik Hadas has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/ma
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: add cpu-mode enumerable values to /capabilities #915042
..
restapi: add cpu-mode enumerable values to /capabilities #915042
https://bugzilla.redhat
Ayal Baron has posted comments on this change.
Change subject: core:ExportVm.doesStorageDomainhaveSpaceForRequest
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Allon Mureinik has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 3: Verified
Addressed Arik's and Omer's review:
Re the sharedLocks member - removed, as suggested by Arik.
Re
Allon Mureinik has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/bll/s
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 9: Fails
need to add additional validation to backend and UI that will prevent edit when
there are no ho
Arik Hadas has posted comments on this change.
Change subject: frontend: disable cores-per-socket for running VM
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13307
To unsubscribe, visit http://gerrit.ovirt
Arik Hadas has uploaded a new change for review.
Change subject: frontend: disable cores-per-socket for running VM
..
frontend: disable cores-per-socket for running VM
This patch makes the cores per virtual socket list unchangea
Itamar Heim has posted comments on this change.
Change subject: userportal,webadmin: Persist the changes from console popup
..
Patch Set 1:
which persistence mechanism is used?
is it supported by all browsers?
does user need to
Arik Hadas has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/ma
Daniel Paikov has posted comments on this change.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12452
To unsubscribe, visit h
Daniel Paikov has posted comments on this change.
Change subject: core: AddVmFromSnapshot - avoid early end method run
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12267
To unsubscribe, visit http://gerrit
Daniel Erez has posted comments on this change.
Change subject: core: Remove IsVdsWithSameNameExist
..
Patch Set 2:
We should use this query for Host name uniqueness validation in the UI (as we
do using IsVmWithSameNameExist /
Arik Hadas has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules/bll/src/m
Daniel Erez has posted comments on this change.
Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery
..
Patch Set 2:
We might want to use this query for the sub-tab as search is limited for 100
results by default (i
Daniel Erez has posted comments on this change.
Change subject: core: Remove GetAllIdsFromExportDomainQuery
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13280
To unsu
Daniel Erez has posted comments on this change.
Change subject: core: Remove unused IsStoragePoolWithSameNameExist
..
Patch Set 3:
We should use this query for name uniqueness validation in the UI (as we do
using IsVmWithSameN
Doron Fediuck has posted comments on this change.
Change subject: core: Make scheduler a POJO
..
Patch Set 2:
This is coming an the midst of a work Gilad is doing on separating various
scheduling logic parts to a different pac
Allon Mureinik has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/sr
Allon Mureinik has posted comments on this change.
Change subject: core: prevent rollback on VmReplicateDiskFinish success
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Daniel Erez has posted comments on this change.
Change subject: core: Removed the unused GetStorageStatisticsQuery
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13226
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused bookmark queries
..
Patch Set 2:
These classes have been unused for the last 2 years.
We can always bring them back if we decide to implemen
Daniel Erez has posted comments on this change.
Change subject: core: Remove unused GetVGInfoQuery
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13225
To unsubscribe,
Daniel Erez has uploaded a new change for review.
Change subject: core: prevent rollback on VmReplicateDiskFinish success
..
core: prevent rollback on VmReplicateDiskFinish success
Preventing rollback on execution success
(moved
Itamar Heim has posted comments on this change.
Change subject: core: Remove unused bookmark queries
..
Patch Set 2:
what if i want to automate their creation for my admins?
--
To view, visit http://gerrit.ovirt.org/13285
To u
Michael Pasternak has posted comments on this change.
Change subject: core: Remove unused bookmark queries
..
Patch Set 2:
api does not have bookmarks as this is only search queries
which can be stored in client's variable/s
-
Noam Slomianko has uploaded a new change for review.
Change subject: webadmin: show quota tab only for correct DCs
..
webadmin: show quota tab only for correct DCs
- When System was selected in SystemTree the quota tab would not
Omer Frenkel has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/
Omer Frenkel has posted comments on this change.
Change subject: core: lock disks when migrating VMs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13263
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: Remove GetVmsRunningOnVDSCount
..
Patch Set 2: (1 inline comment)
Commit Message
Line 3: AuthorDate:
Allon Mureinik has posted comments on this change.
Change subject: core: Remove GetVmsRunningOnVDS
..
Patch Set 2: (1 inline comment)
Commit Message
Line 3: AuthorDate: 2013-
Allon Mureinik has posted comments on this change.
Change subject: core: Remove GetResrouceUsage constant
..
Patch Set 2: (1 inline comment)
Commit Message
Line 3: AuthorDate
Daniel Erez has posted comments on this change.
Change subject: webadmin: error in custom properties sheet
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery
..
Patch Set 2: (1 inline comment)
File
backend/manager/mo
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 9: (5 inline comments)
File
backend/manager/modules
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: error in custom properties sheet
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13304
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 9: Looks good to me, but someone else must approve
(5 inline comments)
some minor comments/questions,
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: DC 'hangs' in local SD
..
webadmin: DC 'hangs' in local SD
In new DC, 'Local on Host':
-> guide-me enters infinite hour glass
Change-Id: I92c
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: DC 'hangs' in local SD
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13300
To unsubscribe, visit http:
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: DC 'hangs' in local SD
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/uicommon
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Conform QuotaListModel to standard
..
webadmin: Conform QuotaListModel to standard
- Fixed QuotaListModel to have the same command method
name
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Conform QuotaListModel to standard
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13275
To unsubscribe,
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: error in custom properties sheet
..
webadmin: error in custom properties sheet
current custom properties sheet doesn't handle cases
where no propertie
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused bookmark queries
..
Patch Set 2:
grep -i bookmark under backend/manager/modules/restapi showed 0 results.
Michael/Itamar - if I'm missing so
1 - 100 of 188 matches
Mail list logo
