Liron Ar has posted comments on this change. Change subject: [wip] core: rename MoveOrCopyImageGroup to CopyImageGroup ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java Line 41 Line 42 Line 43 Line 44 Line 45 the parameters are used for copy and move (like this command name), so IMO the name is fine.. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java Line 96: vm.setStoragePoolId(Guid.NewGuid()); Line 97: return vm; Line 98: } Line 99: }, Line 100: new CopyImageGroupCommand(new MoveOrCopyImageGroupParameters()) { same answer :-) Line 101: @Override Line 102: protected void initContainerDetails(ImagesContainterParametersBase parameters) { Line 103: // No op for test Line 104: } -- To view, visit http://gerrit.ovirt.org/13043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6916e0c864cadc7425cf362da03d90c6f4470959 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches