Daniel Erez has posted comments on this change.
Change subject: webadmin: show quota tab only for correct DCs
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 539: || model.getType() == SystemTreeItemType.Storages ||
model.getType() == SystemTreeItemType.Storage
Line 540: || model.getType() == SystemTreeItemType.System);
Line 541:
Line 542: //only show quota if you select a datacenter that is not
"quota disabled"
Line 543: if(model.getType() == SystemTreeItemType.DataCenter){
please use formatter
Line 544: storage_pool dataCenter = (storage_pool)model.getEntity();
Line 545:
quotaList.setIsAvailable(dataCenter.getQuotaEnforcementType() !=
QuotaEnforcementTypeEnum.DISABLED);
Line 546: } else {
Line 547: quotaList.setIsAvailable(false);
Line 608: // Do not Change Tab if the Selection is the Reports
Line 609: if (!reportsList.getIsAvailable() || getSelectedItem() !=
reportsList) {
Line 610: switch (model.getType())
Line 611: {
Line 612: case System:
We should keep the last selected list in System case.
The solution should probably be specific to Quota.
Line 613: case DataCenter:
Line 614: setSelectedItem(dataCenterList);
Line 615: break;
Line 616: case Clusters:
--
To view, visit http://gerrit.ovirt.org/13305
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7da842adb808838222e5fa40762e7782cd121f6c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
