Allon Mureinik has posted comments on this change.

Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery
......................................................................


Patch Set 2: (1 inline comment)

@Arik - see inline

@Daniel - who can make this call?

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesDisksParameters.java
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4: 
Line 5: public class GetVmTemplatesDisksParameters extends 
VdcQueryParametersBase {
Line 6:     private static final long serialVersionUID = 4859370588871811757L;
Line 7:     private Guid id = new Guid();
Changing this caused all sorts of funky REST-API test fails.

Let's leave this to a later cleanup?
Line 8: 
Line 9:     public GetVmTemplatesDisksParameters(Guid vmTemplateId) {
Line 10:         id = vmTemplateId;
Line 11:     }


--
To view, visit http://gerrit.ovirt.org/13281
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieef493712c75bc386dce066f9774ffe83c1be8fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to