Tomas Jelinek has posted comments on this change.
Change subject: engine: VM Linux Boot options aren't parsing properly
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9550
To unsubscribe,
Aravinda VK has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 5: (3 inline comments)
Will submit new patch set with the changes.
..
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Disable gluster hook command
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11073
To unsubscr
Yair Zaslavsky has posted comments on this change.
Change subject: core: add support for tunnel migration
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/com
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing using of latch all around a code
..
Patch Set 1: (2 inline comments)
File
backend/manager
Yair Zaslavsky has posted comments on this change.
Change subject: core:Async Tasks cleaner utility...
..
Patch Set 5:
Eli, bare in mind that the utility of 3.0 -> 3.1 presented the tasks by groups
of commands - stored procedu
Yair Zaslavsky has posted comments on this change.
Change subject: engine : User is UNKNOWN in async task completion events
..
Patch Set 3: (1 inline comment)
File
backend/m
Selvasundaram has uploaded a new change for review.
Change subject: engine: Disable gluster hook command
..
engine: Disable gluster hook command
Disable the gluster hook in all available up servers in the gluster cluster.
-
Dan Kenigsberg has posted comments on this change.
Change subject: core: add support for tunnel migration
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscripts/u
Greg Padgett has uploaded a new change for review.
Change subject: webadmin: Add DC column to main tab Cluster view
..
webadmin: Add DC column to main tab Cluster view
Add Data Center column to main tab Cluster view.
Change-Id:
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: Do not submit
Please fix this in the API. The specific line of code you want to look at i
Moti Asayag has posted comments on this change.
Change subject: gluster: Make set option a step of create volume
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
..
Yair Zaslavsky has uploaded a new change for review.
Change subject: tools: Adding Setting ldap servers for domain
..
tools: Adding Setting ldap servers for domain
This patch adds support for setting ldap servers for
a given dom
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Supporting hard coded ldap servers per domain
..
core: Supporting hard coded ldap servers per domain
Adding support for hard coded ldap server list per d
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding ldap server ordering algorithms factory
..
core: Adding ldap server ordering algorithms factory
The following adds ldap server ordering logic as p
Eli Mesika has posted comments on this change.
Change subject: core:Async Tasks cleaner utility...
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: (1 inline comment)
File src/engine-iso-u
Greg Padgett has posted comments on this change.
Change subject: webadmin: fetch bookmarks only when tab is shown
..
Patch Set 1: Looks good to me, but someone else must approve
Looks good. If other widgets in the panel need a
Einav Cohen has posted comments on this change.
Change subject: engine: only supported models should use search paging
..
Patch Set 1: (2 inline comments)
File
backend/manag
Moti Asayag has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/uic
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: No score; No score
(1 inline comment)
...
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: (1 inline comment)
File src/engine-iso-u
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: Verified; Looks good to me, approved
(1 inline comment)
.
Alexander Wels has posted comments on this change.
Change subject: webadmin: fetch bookmarks only when tab is shown
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11060
Alissa Bonas has posted comments on this change.
Change subject: core: TrybackToAllSnapshots vmDown validation
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Doron Fediuck has posted comments on this change.
Change subject: Send http 400 when the cpu pinning is wrong
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11059
To un
Alex Lourie has posted comments on this change.
Change subject: packaging: updated setup to fail immediately if adding host
fails
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/10578
To unsubscribe, visit h
Tal Nisan has posted comments on this change.
Change subject: core: VM is down check when adding template
..
Patch Set 2: Looks good to me, approved
Still can't figure out how you manage to count the booleans in each of the
pa
Omer Frenkel has posted comments on this change.
Change subject: core: add support for tunnel migration
..
Patch Set 1: Fails
didn't verify yet
--
To view, visit http://gerrit.ovirt.org/11062
To unsubscribe, visit http://gerri
Omer Frenkel has uploaded a new change for review.
Change subject: core: add support for tunnel migration
..
core: add support for tunnel migration
with 'tunnel migration' the migration process is using
libvirt-to-libvirt commun
Tal Nisan has posted comments on this change.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
..
Patch Set 2: Looks good to me, but someone else must approve
Looks good, but tests are a good idea
--
To view,
Tal Nisan has posted comments on this change.
Change subject: core: Consolidate vm down check when removing disk
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11013
To unsubscribe, visit h
Tal Nisan has posted comments on this change.
Change subject: core: RemoveSnapshot vmDown validation
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
File
back
Tal Nisan has posted comments on this change.
Change subject: core: TrybackToAllSnapshots vmDown validation
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11015
To unsubscribe, visit http:/
Tal Nisan has posted comments on this change.
Change subject: core: ExportVm vmDown validation
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11016
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: updated setup to fail immediately if adding host
fails
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Einav Cohen has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1:
> going fw, we need to support paging for this field.
not sure about the paging (could be), but we'd might
Tal Nisan has posted comments on this change.
Change subject: core: MoveVm vmDown validation
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11017
To unsubscribe, visit http://gerrit.ovirt.o
Gilad Chaplik has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1: Do not submit
probably will abandon this patch.
on a second thought, going fw, we need to support paging
Gilad Chaplik has uploaded a new change for review.
Change subject: engine: only supported models should use search paging
..
engine: only supported models should use search paging
Currently only main tabs support paging, that m
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: fetch bookmarks only when tab is shown
..
webadmin: fetch bookmarks only when tab is shown
And stop fetching when the tab is hidden.
Change-Id: Iebc1
Yair Zaslavsky has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
..
Patch Set 4: (1 inline comment)
F
Gilad Chaplik has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1:
there is a slight problem with over-crowding the UI that we need to solve.
and actually this patch will
Tal Nisan has posted comments on this change.
Change subject: core: Remove checkVmDown from PerformImagesChecks
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11018
To unsubscribe, visit ht
Tal Nisan has posted comments on this change.
Change subject: core: remove unused code and fix param name
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11022
To unsubscribe, visi
Einav Cohen has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1: Looks good to me, but someone else must approve
Gilad - any chance to address Alona's comment about the one
Allon Mureinik has posted comments on this change.
Change subject: core: Remove checkVmDown from PerformImagesChecks
..
Patch Set 2: Verified
rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/11018
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: MoveVm vmDown validation
..
Patch Set 2: Verified
rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/11017
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
..
Patch Set 3: (3 inline comments)
Allon Mureinik has posted comments on this change.
Change subject: core: ExportVm vmDown validation
..
Patch Set 2: Verified
rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/11016
To unsubscribe, visit http:/
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Make set option a step of create volume
..
Patch Set 1: (2 inline comments)
Will send new patch-set, incorporating Moti's suggestions.
...
Yaniv Dary has submitted this change and it was merged.
Change subject: history: fixed post upgrade enum change issue
..
history: fixed post upgrade enum change issue
Change-Id: I9e2139f436a42135ded32e14d02687c1057e8cd3
Signed-
Yaniv Dary has posted comments on this change.
Change subject: history: fixed post upgrade enum change issue
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11055
To unsubscribe, v
Yaniv Dary has uploaded a new change for review.
Change subject: history: fixed post upgrade enum change issue
..
history: fixed post upgrade enum change issue
Change-Id: I9e2139f436a42135ded32e14d02687c1057e8cd3
Signed-off-by:
Shireesh Anjal has abandoned this change.
Change subject: gluster: release lock in canDoActionOnly()
..
Patch Set 2: Abandoned
Taken care with a different approach in http://gerrit.ovirt.org/#/c/10812
--
To view, visit http://
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: GlusterMultipleActionRunner
..
gluster: GlusterMultipleActionRunner
Gluster commands always acquire a lock on the cluster. This means that
if
Shireesh Anjal has posted comments on this change.
Change subject: gluster: GlusterMultipleActionRunner
..
Patch Set 4: Looks good to me, approved
Merging based on Michael's +2
--
To view, visit http://gerrit.ovirt.org/10812
T
Shireesh Anjal has posted comments on this change.
Change subject: gluster: GlusterMultipleActionRunner
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10812
To unsubscribe, visit http://gerrit.ovirt.org/sett
Shireesh Anjal has posted comments on this change.
Change subject: api: Add support for GlusterFS in api.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8844
To unsubsc
Michael Kublin has posted comments on this change.
Change subject: gluster: GlusterMultipleActionRunner
..
Patch Set 3: Looks good to me, approved
The problem is actually the design of MultipleActionRunner,
so we will need to i
Eli Mesika has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1: Looks good to me, but someone else must approve
DB stuff OK
--
To view, visit http://gerrit.ovirt.org/11041
Roy Golan has posted comments on this change.
Change subject: webadmin: improve warning on SPICE Native usb migration support
..
Patch Set 2: (1 inline comment)
File
fronten
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Copy postgresql-jdbc.jar instead of link
..
Patch Set 1:
The new thing is that we actually use this after installation, while we try to
avoid doing th
Shireesh Anjal has posted comments on this change.
Change subject: core: Adding locks in case of gluster hosts
..
Patch Set 2: (2 inline comments)
new patch-set to follow.
F
Juan Hernandez has posted comments on this change.
Change subject: packaging: Copy postgresql-jdbc.jar instead of link
..
Patch Set 1:
I can think of several operating systems that don't provide that package.
Our build system
Omer Frenkel has posted comments on this change.
Change subject: gluster: GlusterMultipleActionRunner
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10812
To unsubscrib
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Copy postgresql-jdbc.jar instead of link
..
Patch Set 1:
When does it happen? Which 'system' does not have postgres jdbc package?
I really don't like
Juan Hernandez has posted comments on this change.
Change subject: packaging: Copy postgresql-jdbc.jar instead of link
..
Patch Set 1: Verified
Verified building/installing/configuring new packages.
--
To view, visit http://ge
Omer Frenkel has posted comments on this change.
Change subject: core: Adding locks in case of gluster hosts
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Copy postgresql-jdbc.jar instead of link
..
packaging: Copy postgresql-jdbc.jar instead of link
Currently we create a symbolic link to the postgresq
Shireesh Anjal has posted comments on this change.
Change subject: core: Add GlusterFS support to AsyncDataProvider
..
Patch Set 4:
I can see the method IsVersionMatchStorageType() in AsyncDataProvider. Am I
looking at the wro
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal,webadmin: console error message translation ignored
..
userportal,webadmin: console error message translation ignored
When the SPICE or RDP console r
Shireesh Anjal has posted comments on this change.
Change subject: core: Adding locks in case of gluster hosts
..
Patch Set 1: (1 inline comment)
new patch-set to follow.
Fi
Omer Frenkel has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
..
Patch Set 2: (2 inline comments)
Fi
Michael Kublin has posted comments on this change.
Change subject: core: Adding locks in case of gluster hosts
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
Michael Kublin has posted comments on this change.
Change subject: engine: Removing using of latch all around a code
..
Patch Set 1: (2 inline comments)
File
backend/manager
Itamar Heim has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
..
Patch Set 2: (1 inline comment)
File
Ravi Nori has posted comments on this change.
Change subject: engine: Removing using of latch all around a code
..
Patch Set 1: (2 inline comments)
File
backend/manager/modu
Alona Kaplan has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
+1 for frontend
.
Alexander Wels has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerr
Yaniv Bronhaim has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
..
Patch Set 2: Verified
missed the string list.
now it works properly,
Might be nicer w
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: add missing .gitignores to dist
..
build: add missing .gitignores to dist
Change-Id: Ie7e72995a00ee6a68e7ed631fa498bf0463b35ae
Signed-off-by: Alon
Alon Bar-Lev has posted comments on this change.
Change subject: build: add missing .gitignores to dist
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11050
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: build: add missing .gitignores to dist
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11049
To unsubscribe, visit
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: add missing .gitignores to dist
..
build: add missing .gitignores to dist
Change-Id: Icc3f8c1f90193a252be6af045c58a2b552a06826
Signed-off-by: Alon
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: add missing .gitignores to dist
..
build: add missing .gitignores to dist
Change-Id: Ie7e72995a00ee6a68e7ed631fa498bf0463b35ae
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: add missing .gitignores to dist
..
build: add missing .gitignores to dist
Change-Id: Icc3f8c1f90193a252be6af045c58a2b552a06826
Signed-off-by: Alon Bar-Lev
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: replace mvn-release plugin with local
..
sdk: replace mvn-release plugin with local
Change-Id: I4ee2aa4edb306eed465eb14451a3837e39351800
Signed
Michael Pasternak has posted comments on this change.
Change subject: sdk: replace mvn-release plugin with local
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11048
To unsubscrib
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: replace mvn-release plugin with local
..
sdk: replace mvn-release plugin with local
Change-Id: I4ee2aa4edb306eed465eb14451a3837e39351800
Signed-off-by:
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: improve behavior of bookmark list (2/2)
..
webadmin: improve behavior of bookmark list (2/2)
This patch series fixes some problems with the be
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: improve behavior of bookmark list (2/2)
..
Patch Set 3: Verified; Looks good to me, approved
Managed to reproduce it in oVirt (some-kind of a race) (th
Alex Lourie has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
...
Alexander Wels has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Gilad Chaplik has posted comments on this change.
Change subject: engine: use vds query instead of search
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/u
Yair Zaslavsky has submitted this change and it was merged.
Change subject: build: use release java packages of otopi and ovirt-host-deploy
..
build: use release java packages of otopi and ovirt-host-deploy
Change-Id: I5a06b720
Yair Zaslavsky has posted comments on this change.
Change subject: build: use release java packages of otopi and ovirt-host-deploy
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: Select english when browser is other locale
..
webadmin: Select english when browser is other locale
- Fixed ability to select English (which was def
Shireesh Anjal has posted comments on this change.
Change subject: core: Introduce AddGlusterFsStorageDomainCommand.
..
Patch Set 3: (1 inline comment)
File
backend/manager/
1 - 100 of 225 matches
Mail list logo
