Yair Zaslavsky has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 518: if (FeatureSupported.hardwareInfo(clusterCompatibility) &&
Line 519: // If the feature is enabled in cluster level, we
continue by verifying that this VDS also
Line 520: // supports the specific cluster level. Otherwise
getHardwareInfo API won't exist for the
Line 521: // host and an exception will be raised by vdsm.
Line 522:
vds.getSupportedClusterVersionsSet().contains(clusterCompatibility)) {
Please add nullability check
Line 523: VDSReturnValue ret =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.GetHardwareInfo,
Line 524: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 525: if (!ret.getSucceeded()) {
Line 526: AuditLogableBase logable = new
AuditLogableBase(vds.getId());
--
To view, visit http://gerrit.ovirt.org/11027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I240786444bdf393f6df4e53daf94d0ee197ecb73
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
