Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File src/engine-iso-uploader.py
Line 413: if self.configuration.get("insecure"):
Line 414: params["insecure"] = True
Line 415: # Otherwise, use ca_file
Line 416: else:
Line 417: params["ca_file"] =
self.configuration.get("engine_ca")
Hello All,
Keith help me to understand what I failed to understand... the separation
between this module and the SDK module, I thought these are related but the API
is object of the engine sdk project.
The following notation is *CORRECT* and expected to work correctly:
self.api = API(
url=url,
username=self.configuration.get("user"),
password=self.configuration.get("passwd"),
ca_file=self.configuration.get("engine_ca"),
insecure=self.configuration.get("insecure", False),
)
If it does not, there is a bug in the API, which refer to SSL/TLS parameters
even if insecure is False.
What we need is to validate that the API indeed behaves incorrectly and fix the
API.
Line 418:
Line 419: # Create an API object
Line 420: self.api = API(**params)
Line 421:
--
To view, visit http://gerrit.ovirt.org/10815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I015c6b5441f0d1e33bb3aae378a59ad8557f9da5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
