Michael Kublin has posted comments on this change.
Change subject: core: Adding locks in case of gluster hosts
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 446: @Override
Line 447: protected Map<String, String> getExclusiveLocks() {
Line 448: if (getVdsGroup().supportsGlusterService() &&
!isInternalExecution()) {
Line 449: return
Collections.singletonMap(getVdsGroupId().toString(),
LockingGroup.GLUSTER.name());
Line 450: }
You don't need call to super method
Line 451: return super.getExclusiveLocks();
Line 452: }
--
To view, visit http://gerrit.ovirt.org/10850
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9d4fec2fafd5f9f32521025da301f8b07b6e713
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
