Alona Kaplan has posted comments on this change.
Change subject: engine: use vds query instead of search
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
+1 for frontend
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 438: * By default admin query is fired, UserPortal overrides it to
fire user query
Line 439: */
Line 440: private void getHostListByCluster(VDSGroup cluster, AsyncQuery
query) {
Line 441: AsyncDataProvider.GetHostListByCluster(query,
cluster.getId());
Line 442: }
I think that it is bad practice to have a method with one simple line.
Line 443:
Line 444: protected void updateCustomPropertySheet() {
Line 445: if (getModel().getCluster().getSelectedItem() == null) {
Line 446: return;
--
To view, visit http://gerrit.ovirt.org/11041
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6d14448dd546135778b63a96924f8d28d1f13bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
