Gianluca Cecchi has posted comments on this change.
Change subject: fix allinone version to 3.2 for dc/cluster default version
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Applied patch to scratch i
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Ori Liel has posted comments on this change.
Change subject: restapi: deprecated move VM (replaced by move disk)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10689
To
Ori Liel has posted comments on this change.
Change subject: restapi: deprecated move VM (replaced by move disk)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10689
To unsubscribe, visit h
Oved Ourfali has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http:/
Selvasundaram has posted comments on this change.
Change subject: engine: Get gluster hooks query
..
Patch Set 1: (2 inline comments)
Commit Message
Line 5: CommitDate: 2013-
Livnat Peer has posted comments on this change.
Change subject: engine: Allow updating network if not used by hosts
..
Patch Set 5:
For removing a network that is attached to a cluster we also need to take care
of the VMs usin
Ayal Baron has posted comments on this change.
Change subject: core: Update image statuses to OK on upgrade.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10699
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 4:
Patchset 4:
Fixed failure issues.
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 3:
Ravi, this fails as getalldisks got changed, and now it receives 3 arg
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 3: Fails; No score
Fails - performed git fetch/rebase
Ran create_db_devel
Yair Zaslavsky has posted comments on this change.
Change subject: core: Update image statuses to OK on upgrade.
..
Patch Set 1:
Question/Suggestion -
Don't we want this as pre-upgrade step?
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: core: DB - Insure that there are no null values...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10702
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: core: DB Adding missing check to fix...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10701
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: core: DB - check if contraint exists before...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10700
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Update image statuses to OK on upgrade.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10699
To unsubscribe, visit http://gerrit.ovirt.o
Eli Mesika has uploaded a new change for review.
Change subject: core: DB Adding missing check to fix...
..
core: DB Adding missing check to fix...
DB Adding missing check to fix duplicate key violation
Checking if key exists b
Eli Mesika has uploaded a new change for review.
Change subject: core: DB - check if contraint exists before...
..
core: DB - check if contraint exists before...
DB - check if constraint exists before attempting to drop it.
Che
Eli Mesika has uploaded a new change for review.
Change subject: core: DB - Insure that there are no null values...
..
core: DB - Insure that there are no null values...
DB - Insure that there are no null values for entity_type
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Update image statuses to OK on upgrade.
..
core: Update image statuses to OK on upgrade.
Update statuses from LOCKED to OK only if no tasks
exists, and use
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Muli Salem has uploaded a new change for review.
Change subject: engine: Release Mac from Pool
..
engine: Release Mac from Pool
This patch makes sure the Mac address is
released from pool in case the Update/Add
VmInterfaceComman
Muli Salem has uploaded a new change for review.
Change subject: engine: Support Duplicate Mac Addresses
..
engine: Support Duplicate Mac Addresses
This patch adds support to duplicate Mac addresses.
It separates the logic in Ma
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: bridge: drop usage of util.getDefault()
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10695
To unsubscribe,
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: bridge: drop usage of util.getDefault()
..
vdsm: bridge: drop usage of util.getDefault()
Change-Id: Iba23c97ab98bf0581d909dad328dc44184aa73ce
Signe
Alon Bar-Lev has posted comments on this change.
Change subject: packagers: yum: support the async URLGrabber
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10694
To unsubscribe,
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packagers: yum: support the async URLGrabber
..
packagers: yum: support the async URLGrabber
yum uses python-urlgrabber to grab files, but does not allow
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: remove getDefault(), getKey() functions
..
core: remove getDefault(), getKey() functions
Change-Id: I213dc604b756f11dacfa006118ac44382a5458b9
Signe
Alon Bar-Lev has posted comments on this change.
Change subject: core: remove getDefault(), getKey() functions
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10693
To unsubscribe,
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: bridge: drop usage of util.getDefault()
..
vdsm: bridge: drop usage of util.getDefault()
Change-Id: Iba23c97ab98bf0581d909dad328dc44184aa73ce
Signed-off-by
Alon Bar-Lev has uploaded a new change for review.
Change subject: packagers: yum: support the async URLGrabber
..
packagers: yum: support the async URLGrabber
yum uses python-urlgrabber to grab files, but does not allow setting
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: remove getDefault(), getKey() functions
..
core: remove getDefault(), getKey() functions
Change-Id: I213dc604b756f11dacfa006118ac44382a5458b9
Signed-off-by
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: version values for hosts are wrong
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
I understand the reason engine-s
Moti Asayag has uploaded a new change for review.
Change subject: engine: Restrict vlan-id range to 0-4094
..
engine: Restrict vlan-id range to 0-4094
VDSM restricts vlan-id range to 0-4094 due to Linux limitation.
The engine sh
Yair Zaslavsky has posted comments on this change.
Change subject: core:Can not upgrade from 3.1 to 3.2
..
Patch Set 1: No score
(1 inline comment)
Eli, Please see Kiri's comment- I think you meant the 2nd parameter to accept
Yair Zaslavsky has posted comments on this change.
Change subject: restapi : list files with --max issue
..
Patch Set 1: Looks good to me, but someone else must approve
Maor, please review as well.
--
To view, visit http://ger
Liron Aravot has uploaded a new change for review.
Change subject: core: return object locked message when storage domain is
locked.
..
core: return object locked message when storage domain is locked.
This patch changed the re
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8
Kiril Nesenko has posted comments on this change.
Change subject: core:Can not upgrade from 3.1 to 3.2
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts/dbfun
Yair Zaslavsky has posted comments on this change.
Change subject: core:Can not upgrade from 3.1 to 3.2
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10690
To unsubscribe, visit http://ger
Eli Mesika has uploaded a new change for review.
Change subject: core:Can not upgrade from 3.1 to 3.2
..
core:Can not upgrade from 3.1 to 3.2
This patch fix a bug that resulted from commit
6891171a906f708b8751cc583faffc94590e794
Moti Asayag has posted comments on this change.
Change subject: engine: Allow updating network if not used by hosts
..
Patch Set 5:
As for removing the network when it doesn't attached to any host - I'm okay
with it but would
Moti Asayag has posted comments on this change.
Change subject: engine: Allow updating network if not used by hosts
..
Patch Set 4: (1 inline comment)
File backend/manager/mo
Moti Asayag has submitted this change and it was merged.
Change subject: core: Rename can-do-action message name and description
..
core: Rename can-do-action message name and description
Can-do-action message renamed to reflec
Moti Asayag has posted comments on this change.
Change subject: core: Rename can-do-action message name and description
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10685
To uns
Moti Asayag has posted comments on this change.
Change subject: core: Rename can-do-action message name and description
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/10685
To unsubscribe, visit http://gerri
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin,userportal: Unicode support for NIC name
..
webadmin,userportal: Unicode support for NIC name
Using I18NNameValidation for supporting
Unicode cha
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Unicode support for NIC name
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10563
To
Daniel Erez has posted comments on this change.
Change subject: restapi: adding support for moving a VM disk
..
Patch Set 2:
deprecated '/api/vms/{vm:id}/move|rel=move'
on http://gerrit.ovirt.org/#/c/10689/
--
To view, visit h
Gilad Chaplik has posted comments on this change.
Change subject: core: removing unused static class
..
Patch Set 1:
LOL :-)
--
To view, visit http://gerrit.ovirt.org/8877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mike Kolesnik has posted comments on this change.
Change subject: engine: Allow updating network if not used by hosts
..
Patch Set 4: (1 inline comment)
Perhaps this could be done also for remove network command (in separate pa
Mike Kolesnik has posted comments on this change.
Change subject: core: Rename can-do-action message name and description
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10685
To unsubscribe
Daniel Erez has uploaded a new change for review.
Change subject: restapi: copy disk - fixing rsdl and SD lookup method
..
restapi: copy disk - fixing rsdl and SD lookup method
* rsdl:
mandatory arguments - changing to 'storaged
Daniel Erez has uploaded a new change for review.
Change subject: restapi: deprecated move VM (replaced by move disk)
..
restapi: deprecated move VM (replaced by move disk)
Deprecated '/api/vms/{vm:id}/move|rel=move'
replaced by
Mike Kolesnik has posted comments on this change.
Change subject: core: Rename can-do-action message name and description
..
Patch Set 4: (1 inline comment)
Commit Message
Li
Mike Kolesnik has posted comments on this change.
Change subject: engine: Improved error message when unassigning network used by
VMs
..
Patch Set 1: (6 inline comments)
Good job, just a few comments.
Also, maybe a follow up
Alona Kaplan has posted comments on this change.
Change subject: webadmin,userportal: Unicode support for NIC name
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
.
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3165/
Build Number: 3165
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,861,
Started by upstream project "ovirt_engine" build numb
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modu
Michael Pasternak has posted comments on this change.
Change subject: engine: version values for hosts are wrong
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: Aut
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3164/
Build Number: 3164
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,860
-
Changes
Omer Frenkel has posted comments on this change.
Change subject: core:StorageHelper cleanup, code clean
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10140
To unsubscr
Lior Vernia has posted comments on this change.
Change subject: engine: Improved error message when unassigning network used by
VMs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10683
To unsubscribe, visit
Lior Vernia has uploaded a new change for review.
Change subject: engine: Improved error message when unassigning network used by
VMs
..
engine: Improved error message when unassigning network used by VMs
Added to the error mes
Omer Frenkel has submitted this change and it was merged.
Change subject: core: ImportVm - use device info only if supported
..
core: ImportVm - use device info only if supported
vm devices were intoduced only in 3.1
when impor
Omer Frenkel has posted comments on this change.
Change subject: core: ImportVm - use device info only if supported
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10625
To unsubsc
Moti Asayag has submitted this change and it was merged.
Change subject: engine: CanDoAction of Update/AddNetworkCommand
..
engine: CanDoAction of Update/AddNetworkCommand
This patch aggregates the if statements in the
canDoAct
Moti Asayag has posted comments on this change.
Change subject: engine: CanDoAction of Update/AddNetworkCommand
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10626
To unsubscribe
Liron Aravot has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9070
To unsubsc
Arik Hadas has posted comments on this change.
Change subject: core: add "disabled" feature to template
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/util
Roy Golan has posted comments on this change.
Change subject: core: ImportVm - use device info only if supported
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10625
To unsubscribe, visit h
Mike Kolesnik has posted comments on this change.
Change subject: engine: CanDoAction of Update/AddNetworkCommand
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10626
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: engine: CanDoAction of Update/AddNetworkCommand
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/10626
To unsubscribe, visit http://gerrit.ovirt.
Mike Kolesnik has posted comments on this change.
Change subject: engine: CanDoAction of Update/AddNetworkCommand
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10626
To unsubscribe, visit
Ravi Nori has uploaded a new change for review.
Change subject: engine: version values for hosts are wrong
..
engine: version values for hosts are wrong
When the host is being installed or is being rebooted
the version value is
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper cleanup, code clean
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/bll/
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper cleanup, use one log declaration.
..
core:StorageHelper cleanup, use one log declaration.
Declare log only at StorageHelperBase instea
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper cleanup, use one log declaration.
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper clenups, Use formatter.
..
core:StorageHelper clenups, Use formatter.
Use formatter in storage helper classes.
Change-Id: I7c141cf02d
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper clenups, Use formatter.
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org/10138
To u
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(13).
..
core:StorageHelper Cleanup, method name standard(13).
Change method name isConnectSucceeded to b
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(13).
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(12).
..
core:StorageHelper Cleanup, method name standard(12).
Change method name getStorageServerConnect
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(12).
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(11).
..
core:StorageHelper Cleanup, method name standard(11).
Change method name ValidateStoragePoolConn
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(11).
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(10).
..
core:StorageHelper Cleanup, method name standard(10).
Change method name storageDomainRemoved to
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(10).
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(9).
..
core:StorageHelper Cleanup, method name standard(9).
Change method name connectStorageToLunByVdsI
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(9).
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org/
Moti Asayag has uploaded a new change for review.
Change subject: core: Rename can-do-action message name and description
..
core: Rename can-do-action message name and description
Can-do-action message renamed to reflect what i
Moti Asayag has uploaded a new change for review.
Change subject: engine: Allow updating network if not used by hosts
..
engine: Allow updating network if not used by hosts
The requirement for updating network only if not attach
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(8).
..
core:StorageHelper Cleanup, method name standard(8).
Change method name disconnectStorageFromLunB
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(8).
..
Patch Set 5: Verified; Looks good to me, approved
Acked by Tal
--
To view, visit http://gerrit.ovirt.org/
Liron Aravot has uploaded a new change for review.
Change subject: core: fixes to import/OvfDataUpdater issues
..
core: fixes to import/OvfDataUpdater issues
The following patch fixes a case in which we attempt to insert a recor
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 1:
IIRC one view should be removed?
--
To view, visit http://gerrit.ovirt.org/10573
To unsubscribe, vi
Ravi Nori has posted comments on this change.
Change subject: restapi : Custom property values with multiple "=" not
returned (#886802)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10160
To unsubscribe,
Doron Fediuck has posted comments on this change.
Change subject: userportal: pull-up syncSearch in basic and advanced view
..
Patch Set 1: Looks good to me, but someone else must approve
Nice cleanup.
--
To view, visit http:/
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: VM-runtime-only information presented after VM goes
down (#869682)
..
restapi: VM-runtime-only information presented after VM goes down (#8
Michael Pasternak has posted comments on this change.
Change subject: restapi: VM-runtime-only information presented after VM goes
down (#869682)
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt
1 - 100 of 208 matches
Mail list logo
