Arik Hadas has posted comments on this change.
Change subject: core: add "disabled" feature to template
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
Line 160: }
Line 161:
Line 162: node = content.SelectSingleNode("IsDisabled");
Line 163: if (node != null) {
Line 164: if (!StringUtils.isEmpty(node.InnerText)) {
the inner if clause is not necessary because Boolean.parseBoolean can handle
null or empty strings
Line 165:
_vmTemplate.setDisabled(Boolean.parseBoolean(node.InnerText));
Line 166: }
Line 167: }
Line 168: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 184: ACTION_TYPE_FAILED_CANNOT_REMOVE_ACTIVE_IMAGE=Cannot ${action}
${type}. Removing the VM active Snapshot is not allowed.
Line 185: ACTION_TYPE_FAILED_PROBLEM_WITH_CANDIDATE_INFO=Cannot ${action}
${type}. Failed to get data for Import operation.\n\
Line 186: - Check your Import Domain.
Line 187: ACTION_TYPE_FAILED_TEMPLATE_DOES_NOT_EXIST=Cannot ${action} ${type}.
The relevant Template doesn't exist.
Line 188: ACTION_TYPE_FAILED_TEMPLATE_IS_DISABLED=Cannot ${action} ${type}. The
Template is disabled, please try to enable the template first and try again.
suggestion - replace the error with the following text:
"The relevant Template is disabled, thus cannot be used to create new VMs"
Line 189: ACTION_TYPE_FAILED_IMAGE_ALREADY_EXISTS=Cannot ${action} ${type}. One
of the Template Images already exists.
Line 190: ACTION_TYPE_FAILED_TEMPLATE_NAME_ALREADY_EXISTS=Cannot ${action}
${type}. A Template with the same name already exists.
Line 191: ACTION_TYPE_FAILED_TEMPLATE_GUID_ALREADY_EXISTS=Cannot ${action}
${type}. A Template with the same identifier already exists.
Line 192: ACTION_TYPE_FAILED_CANDIDATE_ALREADY_EXISTS=Cannot ${action} ${type}.
The export candidate already exists in the specified path.\n\
--
To view, visit http://gerrit.ovirt.org/10502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f8b60280d76b73a26f0d5feaf6650c7ef7ce7e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
