Yair Zaslavsky has posted comments on this change.
Change subject: core:Can not upgrade from 3.1 to 3.2
......................................................................
Patch Set 1: No score
(1 inline comment)
Eli, Please see Kiri's comment- I think you meant the 2nd parameter to accept
the db name?
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 86: execute_command "$CMD" ${DATABASE} ${SERVERNAME} ${PORT} >
drop_all_functions.sql
Line 87: execute_file "drop_all_functions.sql" ${DATABASE} ${SERVERNAME}
${PORT} > /dev/null
Line 88: \rm -f drop_all_functions.sql
Line 89: #drop old uuid functions
Line 90: psql -U postgres -h ${SERVERNAME} -h ${SERVERNAME} -p ${PORT} -f
drop_old_uuid_functions.sql ${DATABASE} > /dev/null
Right, not needed. only one occurance is required.
I would expect a parameter for dbname.
Line 91: # recreate generic functions
Line 92: execute_file "create_functions.sql" ${DATABASE} ${SERVERNAME}
${PORT} > /dev/null
Line 93: }
Line 94:
--
To view, visit http://gerrit.ovirt.org/10690
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbd051b30917827dd5dcf357cfcb5a6934ff589
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
