Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
Line 27: import org.ovirt.engine.ui.uicommonweb.validation.LengthValidation;
Line 28: import org.ovirt.engine.ui.uicommonweb.validation.NotEmptyValidation;
Line 29: import org.ovirt.engine.ui.uicompat.ConstantsManager;
Line 30:
Line 31: public class ClusterModel extends ClusterPolicyModel
I'm not okay with ClusterModel to extend ClusterPolicyModel.
please contain it.
Line 32: {
Line 33: private int privateServerOverCommit;
Line 34:
Line 35: public int getServerOverCommit()
--
To view, visit http://gerrit.ovirt.org/10573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I195d9ec1c7901a31e6e656221964d82bc90c9695
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
