Selvasundaram has posted comments on this change.

Change subject: engine: Get gluster hooks query
......................................................................


Patch Set 1: (2 inline comments)

....................................................
Commit Message
Line 5: CommitDate: 2013-01-04 11:21:05 +0530
Line 6: 
Line 7: engine: Get gluster hooks query
Line 8: 
Line 9:     - Fetch the gluster hooks from the db.
It is low level gluster hooks only.
Line 10:       If no hooks found from the db, query will fetch from the vdsm 
and update the db.
Line 11: 
Line 12:     - Introducting runVdsCommand() in the GlusterQueriesCommandBase 
and refactored GetGlusterVolumeProfileInfoQuery,
Line 13:       GetGlusterVolumeOptionsInfoQuery and 
GetGlusterVolumeAdvancedDetailsQuery


Line 6: 
Line 7: engine: Get gluster hooks query
Line 8: 
Line 9:     - Fetch the gluster hooks from the db.
Line 10:       If no hooks found from the db, query will fetch from the vdsm 
and update the db.
* Sync job will update the available gluster hooks. You can see all the gluster 
hooks.
* Gluster always ships with some hooks, it may be either enabled or disabled 
state. Sync job is good enough to populate/update the gluster hooks in DB.
* The query can be as simple as querying gluster hooks from DB (so query never 
go to the vdsm). I will send another patch set with this changes.

* Synching gluster hooks will be send as separate patch.
Line 11: 
Line 12:     - Introducting runVdsCommand() in the GlusterQueriesCommandBase 
and refactored GetGlusterVolumeProfileInfoQuery,
Line 13:       GetGlusterVolumeOptionsInfoQuery and 
GetGlusterVolumeAdvancedDetailsQuery
Line 14: 


--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to