Alon Bar-Lev has posted comments on this change.
Change subject: common: remove Config dependency from front-end.
..
Patch Set 2:
Can anyone tell me how come in business entities we use the Config object at
front-end side? wha
Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfTemplate.
..
Patch Set 5: (2 inline comments)
File
backend/manager/m
Gilad Chaplik has posted comments on this change.
Change subject: common: remove Config dependency from front-end.
..
Patch Set 1: (2 inline comments)
File
backend/manager/m
Gilad Chaplik has posted comments on this change.
Change subject: common: remove Config dependency from front-end.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10263
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 4:
Yair, EventQueueMonitor - line 154
--
To view, visit http://gerrit.ovirt.org/9838
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: core: Fix Remove Storage error message(#863097)
..
Patch Set 1: (4 inline comments)
File
backend/manager/mod
Alon Bar-Lev has posted comments on this change.
Change subject: common: remove Config dependency from front-end.
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Muli Salem has abandoned this change.
Change subject: tools: Adding Reload Configs Implementation (#825671)
..
Patch Set 9: Abandoned
Since we are taking a different approach, this patch is irrelevant.
--
To view, visit http:/
Gilad Chaplik has posted comments on this change.
Change subject: [WIP]core : GWT changes for Multi-Tier fencing
..
Patch Set 1:
IMHO, should be added to the client patch. this is ok also...
--
To view, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Fix Remove Storage error message(#863097)
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
Michal Skrivanek has posted comments on this change.
Change subject: engine: VM Linux Boot options aren't parsing properly
..
Patch Set 3: Looks good to me, but someone else must approve
AFAIC verification is good enough. Typi
Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfVm.
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/
Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to ImportVmTemplateCommand.
..
Patch Set 5: (1 inline comment)
Commit Messa
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand
..
Patch Set 14: (15 inline comments)
File
backend/man
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 4:
Liron, not sure I understood - why it will be cleared?
--
To view, visit http://gerrit.ovirt.or
liron aravot has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 4:
seems to me that the user will have hard time running RecoveryStoragePool
command now, as timers
Yair Zaslavsky has posted comments on this change.
Change subject: common: remove Config dependency from front-end.
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Looks good.
+2 on engine-si
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 4: (1 inline comment)
Added some idea on the small race of putIfAbscent comment.
.
Vered Volansky has posted comments on this change.
Change subject: core: Fix Remove Storage error message(#863097)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10265
To unsubscribe, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: core : DB FK validation
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Vered Volansky has uploaded a new change for review.
Change subject: core: Fix Remove Storage error message(#863097)
..
core: Fix Remove Storage error message(#863097)
setActionMessageParameters() was not set for RemoveStorageDo
Greg Padgett has posted comments on this change.
Change subject: core: Add DB columns for CPU Thread Handling (1/4)
..
Patch Set 3: No score
Un-verifying: code works, but the fields returned by VDSM aren't yet finalized.
--
To
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP]core : BE & DAO changes for Multi-Tier fencing
..
Patch Set 1: (1 inline comment)
File
backend/manage
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP]core : BLL changes for Multi-Tier fencing
..
Patch Set 1:
I will revisit this, did first look, besides the fact due to the definitions of
the feature we h
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP]core: DB Changes for Multi-Tier fencing
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10258
To
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: RFE: Multi-Tier fencing support
..
Patch Set 1: (1 inline comment)
not sure i understand why this is needed
...
Alon Bar-Lev has uploaded a new change for review.
Change subject: common: remove Config dependency from front-end.
..
common: remove Config dependency from front-end.
The only use of class org.ovirt.engine.core.common.config.Co
Eli Mesika has uploaded a new change for review.
Change subject: [WIP] core: RFE: Multi-Tier fencing support
..
[WIP] core: RFE: Multi-Tier fencing support
This series of patches implements the following RFE
http://wiki.ovirt.or
Eli Mesika has uploaded a new change for review.
Change subject: [WIP]core : GWT changes for Multi-Tier fencing
..
[WIP]core : GWT changes for Multi-Tier fencing
Change-Id: I1b17302cd68ab937dbc30978dd577c8eb93d220d
Signed-off-by
Eli Mesika has uploaded a new change for review.
Change subject: [WIP]core : BLL changes for Multi-Tier fencing
..
[WIP]core : BLL changes for Multi-Tier fencing
this patch includes masically changes in the fencing infrastructur
Eli Mesika has uploaded a new change for review.
Change subject: [WIP]core : API changes Multi-Tier fencing
..
[WIP]core : API changes Multi-Tier fencing
Change-Id: Iad50a36b240043fc88a7f4f60ecfaee29c1e147f
Signed-off-by: Eli Me
Eli Mesika has uploaded a new change for review.
Change subject: [WIP]core : BE & DAO changes for Multi-Tier fencing
..
[WIP]core : BE & DAO changes for Multi-Tier fencing
this patch includes the changes in BE & DAO for Multi-Ti
Eli Mesika has uploaded a new change for review.
Change subject: [WIP]core: DB Changes for Multi-Tier fencing
..
[WIP]core: DB Changes for Multi-Tier fencing
This patch includes all relevant changes for Multi-Tier fencing suppor
Eli Mesika has uploaded a new change for review.
Change subject: core : DB FK validation
..
core : DB FK validation
The purpose of this utility is to find inconsistent data that violates
FK(Forign Keys), display it and enable
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 4: Looks good to me, but someone else must approve
Allon, please also take a look.
--
To view, vis
Yair Zaslavsky has posted comments on this change.
Change subject: engine: if connect storage pool fails on version mismatch, do
reconstruct master
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovi
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Switched to the official GWT maven plugin
..
engine: Switched to the official GWT maven plugin
Switched maven GWT plugin to the official one.
Signed-o
Daniel Erez has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 4: (11 inline comments)
File
frontend/webadmin/modu
Allon Mureinik has posted comments on this change.
Change subject: core: Adding LIO iSCSI target as ... (#879272)
..
Patch Set 3: (1 inline comment)
Commit Message
Line 12: L
Allon Mureinik has posted comments on this change.
Change subject: engine: Removing unneeded setVdsId() from constructors
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10235
To unsubscribe
Asaf Shakarchi has uploaded a new change for review.
Change subject: core: Root and Frontend maven poms cleanup
..
core: Root and Frontend maven poms cleanup
- Moved gwt plugin repo from frontend module into root pom
- Descripti
Doron Fediuck has posted comments on this change.
Change subject: engine: template support for cpu host
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
The condition we check should be fixed to ha
Allon Mureinik has posted comments on this change.
Change subject: core: add clear message for live snapshot fail
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10171
To unsubscri
Allon Mureinik has submitted this change and it was merged.
Change subject: core: add clear message for live snapshot fail
..
core: add clear message for live snapshot fail
Add a new, clear message when live snapshot fails for
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Extract code to methods in ImagesHandler
..
core: Extract code to methods in ImagesHandler
Extract code to isVMDown and checking for storage pool
Allon Mureinik has posted comments on this change.
Change subject: core: Extract code to methods in ImagesHandler
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10148
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: core: add clear message for live snapshot fail
..
Patch Set 6: Verified; Looks good to me, approved
Rebased, fixed typo in commit message.
--
To view, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: Extract code to methods in ImagesHandler
..
Patch Set 4: Verified; Looks good to me, approved
rebased, re-verified
--
To view, visit http://gerrit.ovirt.
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Removal of a deprecated Public API moudle.
..
engine: Removal of a deprecated Public API moudle.
This patch removes a deprecated Public API module,
It
Doron Fediuck has posted comments on this change.
Change subject: engine: cpu host feature
..
Patch Set 19: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9753
To unsubscribe, visit http://gerrit.ovirt.org
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: cpu host feature
..
engine: cpu host feature
Adds the engine-side support for cpu-host feature
http://www.ovirt.org/Features/Cpu-host_Support
B
Allon Mureinik has posted comments on this change.
Change subject: core: add clear message for live snapshot fail
..
Patch Set 5: (1 inline comment)
File
backend/manager/mod
Juan Hernandez has posted comments on this change.
Change subject: DO NOT SUBMIT: packaging: Initial commit
..
Patch Set 3: (5 inline comments)
As this package has only one .jar file you may want to consider placing it
directl
Yair Zaslavsky has posted comments on this change.
Change subject: Adding host bios fields to vdsStatic table
..
Patch Set 2: (1 inline comment)
File backend/manager/dbscript
Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 12: I would prefer that you didn't submit this
(5 inline comments)
Pay attention to fixtures.xml
Please run
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Split VM->VmIntererface sub tub
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10242
To unsubscribe, visit http:/
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Define the right GWT version in root pom
..
engine: Define the right GWT version in root pom
Define current used version of GWT which is 2.3.0 instead
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Avoid duplicate server queries
..
Patch Set 4: Verified; No score
--
To view, visit http://gerrit.ovirt.org/9554
To unsubscribe, visit http://gerrit.ov
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Split VM->VmIntererface sub tub
..
webadmin: Split VM->VmIntererface sub tub
A split view of the VM's Network Interfaces sub-tab will present the
infor
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: allow a single user lookup at a time
..
webadmin: allow a single user lookup at a time
In search user (add user/permission),
a query ('GO') may take a
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 24: I would prefer that you didn't submit this
Liron, please note Yair's comment in http://gerrit.ovirt.org/#/c/982
Ofer Schreiber has uploaded a new change for review.
Change subject: packaging: Initial commit
..
packaging: Initial commit
Initial add of the packaging, including Makefile and .spec file
Change-Id: Id6c53ccfe6d5d31f8620ac4fbc5
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: missing translation in Quota ($VmName)
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: missing translation in Quota ($VmName)
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Greg Padgett has posted comments on this change.
Change subject: engine: cpu host feature
..
Patch Set 19: Looks good to me, but someone else must approve
(2 inline comments)
Looks good, just a couple minor comments if you hap
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Removed duplicate repo definition in webadmin root pom
..
engine: Removed duplicate repo definition in webadmin root pom
Removed duplicate repo definit
Vinzenz Feenstra has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10218
To u
Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand
..
Patch Set 14: (1 inline comment)
File
backend/manager
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3025/
Build Number: 3025
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,681
-
Changes Since La
Moti Asayag has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
..
Patch Set 1: (1 inline comment)
Commit Message
Line 6:
Line 7: F
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Make EntityObject class final
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10238
To unsubscribe, visi
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Make EntityObject class final
..
webadmin: Make EntityObject class final
Making EntityObject class final just to be on safe side with regard
to GWT Ja
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing unneeded setVdsId() from constructors
..
Patch Set 1: Looks good to me, but someone else must approve
This exists of course as a result of the
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: CellTable IE8 optimization
..
Patch Set 1:
I tested it a while ago in a real win-xp machine, maybe it gets better but the
diff is neglectab
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: CellTable IE8 optimization
..
Patch Set 1:
> but you override it with empty implementation, and it still has bad
> performance?
Actually t
Vojtech Szocs has posted comments on this change.
Change subject: engine: cpu host feature
..
Patch Set 19: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9753
To unsubscribe, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] engine: User queries improvements
..
Patch Set 9:
fnsplitteruuid does not work with temp table anymore.
Had to change all places that had -
(select ID fr
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: CellTable IE8 optimization
..
Patch Set 1:
but you override it with empty implementation, and it still has bad performance?
--
To view, vis
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 4:
fixed some spelling mistakes and some other remrks
--
To view, visit http://gerrit.ovirt.org/98
Michael Kublin has uploaded a new change for review.
Change subject: engine: Removing unneeded setVdsId() from constructors
..
engine: Removing unneeded setVdsId() from constructors
The following call is unneeded because, it is
Mike Kolesnik has posted comments on this change.
Change subject: core : add NetwrokLinking support to VmInterfaceManager
..
Patch Set 8: (1 inline comment)
File
backend/man
Mike Kolesnik has posted comments on this change.
Change subject: core: create UpdateVmInterfaceVDSCommand
..
Patch Set 11: (5 inline comments)
File
backend/manager/modules/
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 3: (3 inline comments)
File
backend/manager/m
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: windows 8/2012 default user portal console should
be RDP
..
userportal: windows 8/2012 default user portal console should be RDP
Since wind
Tomas Jelinek has posted comments on this change.
Change subject: userportal: windows 8/2012 default user portal console should
be RDP
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.
Tomas Jelinek has posted comments on this change.
Change subject: userportal: windows 8/2012 default user portal console should
be RDP
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
..
Patch Set 26: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9340
To unsub
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 24: Looks good to me, approved
(3 inline comments)
See minor comments
.
Gilad Chaplik has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
..
Patch Set 11:
:-)
--
To view, visit http://gerrit.ovirt.org/10197
To unsubscribe, visit http://gerrit.ovirt
Gilad Chaplik has posted comments on this change.
Change subject: userportal: windows 8/2012 default user portal console should
be RDP
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10211
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
..
Patch Set 11:
Also followed Gilad's comment
--
To view, visit http://gerrit.ovirt.org/10197
To unsubscribe
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3024/
Build Number: 3024
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,676,
Started by upstream project "ovirt_engine" bu
Yair Zaslavsky has submitted this change and it was merged.
Change subject: webadmin: Audit log messages file EOLs set to Unix
..
webadmin: Audit log messages file EOLs set to Unix
Change-Id: If119bb5fd0119ea8c8fad54feedd729a43
Shireesh Anjal has posted comments on this change.
Change subject: engine: gluster action version check added
..
Patch Set 3: (2 inline comments)
File
backend/manager/dbscri
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking support to RunVm command.
..
Patch Set 17: (4 inline comments)
File
backend/manage
Juan Hernandez has posted comments on this change.
Change subject: core: remove unused maven profile
..
Patch Set 1: Looks good to me, but someone else must approve
I never use that profile, in fact I wasn't aware of its existe
Allon Mureinik has posted comments on this change.
Change subject: engine: vmstatic and vmbase cleanup
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9824
To unsubscrib
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Audit log messages file EOLs set to Unix
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10149
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
..
Patch Set 25: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Audit log messages file EOLs set to Unix
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10149
To unsubscribe, vi
1 - 100 of 244 matches
Mail list logo
