Gilad Chaplik has posted comments on this change. Change subject: webadmin: missing translation in Quota ($VmName) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java Line 632: Quota quota = fetchQuotaFromCache(param.getQuotaGuid(), parameters.getStoragePool().getId()); Line 633: if (quota == null) { Line 634: parameters.getCanDoActionMessages().add(VdcBllMessages.ACTION_TYPE_FAILED_QUOTA_IS_NO_LONGER_AVAILABLE_IN_SYSTEM.toString()); Line 635: parameters.getCanDoActionMessages().add(String.format("$%1$s %2$s", "VmName", parameters.getAuditLogable() Line 636: .getVmName())); IMHO you wrote exactly the same thing :) Line 637: auditLogPair.setFirst(param.getParameterType() == QuotaConsumptionParameter.ParameterType.STORAGE ? Line 638: AuditLogType.MISSING_QUOTA_STORAGE_PARAMETERS_PERMISSIVE_MODE: Line 639: AuditLogType.MISSING_QUOTA_CLUSTER_PARAMETERS_PERMISSIVE_MODE); Line 640: log.errorFormat("The quota id {0} is not found in backend and DB.", param.getQuotaGuid().toString()); -- To view, visit http://gerrit.ovirt.org/9662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4777fa20f4663e1ab47e611bbc80aec26ee84166 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches