Michael Kublin has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 101: return queue;
Line 102: }
Line 103:
Line 104: private ReentrantLock getPoolLock(Guid poolId) {
Line 105: if (!poolsLockMap.containsKey(poolId)) {
putIfAbsent is atomic, it will add only no entry.
Line 106: poolsLockMap.putIfAbsent(poolId, new ReentrantLock());
Line 107: }
Line 108: return poolsLockMap.get(poolId);
Line 109: }
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java
Line 10: SCHEDULER, // SchedulerUtil
Line 11: USERS_DOMAINS_CACHE,
Line 12: VDS_EVENT_LISTENER,
Line 13: LOCK_MANAGER,
Line 14: EVENTQUEUE_MANAGER;
Yep, I have problems with rabases, can be done later
Line 15:
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java
Line 86: public static <V> Future<V> execute(FutureTask<V> command) {
Line 87: try {
Line 88: return (Future<V>) es.submit(command);
Line 89: } catch (RejectedExecutionException e) {
Line 90: log.warn("The thread pool is out of limit. A submitted
task was rejected");
No, it is a generic API
Line 91: throw e;
Line 92: }
Line 93: }
--
To view, visit http://gerrit.ovirt.org/9838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
