Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
......................................................................
Patch Set 4: (1 inline comment)
Added some idea on the small race of putIfAbscent comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 101: return queue;
Line 102: }
Line 103:
Line 104: private ReentrantLock getPoolLock(Guid poolId) {
Line 105: if (!poolsLockMap.containsKey(poolId)) {
I agree with Michael's comment from before about the race.
In addition - Since creating new DC is not a too common operation , we can
consider to add a lock to the map upon DC creation (same also for system start).
Lock should be removed of course if DC is succesfully destroyed.
What do you think?
Line 106: poolsLockMap.putIfAbsent(poolId, new ReentrantLock());
Line 107: }
Line 108: return poolsLockMap.get(poolId);
Line 109: }
--
To view, visit http://gerrit.ovirt.org/9838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
