[Engine-patches] Change in ovirt-engine[master]: webadmin: Hiding Dashboard and Quota tabs in Gluster-only mo...

2012-11-29 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: Hiding Dashboard and Quota tabs in Gluster-only mode .. webadmin: Hiding Dashboard and Quota tabs in Gluster-only mode Dashboard and Quota tabs will not

[Engine-patches] Change in ovirt-engine[master]: tools: Exposing ApplicationMode through engine-config

2012-11-29 Thread iheim
Itamar Heim has posted comments on this change. Change subject: tools: Exposing ApplicationMode through engine-config .. Patch Set 1: I'm not sure i agree this should be configurable and not assume by setup. reason: going forwa

[Engine-patches] Change in ovirt-iso-uploader[master]: build: build rewrite using autotools

2012-11-29 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: build: build rewrite using autotools .. Patch Set 3: Alon, I just tried it and I don't think the symlink is working because the target isn't executable. Have

[Engine-patches] Change in ovirt-engine[master]: core: RunVm should send "linkState" to the vdsm.

2012-11-29 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: RunVm should send "linkState" to the vdsm. .. Patch Set 5: (1 inline comment) File backend/manager/modu

[Engine-patches] Change in ovirt-engine[master]: core: add NetworkLinking to AddVmInterfaceCommand

2012-11-29 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: add NetworkLinking to AddVmInterfaceCommand .. Patch Set 12: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: adding engine Maintenance and Prepare mode.

2012-11-29 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: adding engine Maintenance and Prepare mode. .. core: adding engine Maintenance and Prepare mode. Support for that was already merged in http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: adding engine Maintenance and Prepare mode.

2012-11-29 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: adding engine Maintenance and Prepare mode. .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9568 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: VM cleanup

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VM cleanup .. Patch Set 5: (1 inline comment) File backend/manager/modules/bll/src/main/java/org/ovirt/en

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixing engine-config install properties for fc18

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: packaging: Fixing engine-config install properties for fc18 .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9504 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: cleanup and delete EnumCompat

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: cleanup and delete EnumCompat .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9516 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: engine: Delete permissions when Network is deleted

2012-11-29 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Delete permissions when Network is deleted .. engine: Delete permissions when Network is deleted The patch deletes the permissions on a specific network w

[Engine-patches] Change in ovirt-guest-agent[master]: Updated spec file to follow packaging guide lines (BZ#772608...

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Updated spec file to follow packaging guide lines (BZ#772608) .. Patch Set 13: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixing engine-config install properties for fc18

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Fixing engine-config install properties for fc18 .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-iso-uploader[master]: build: build rewrite using autotools

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: build: build rewrite using autotools .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/8855 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: VM cleanup

2012-11-29 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: VM cleanup .. Patch Set 5: Good job , but I think that we should not submit that until all new features are merged, if it will be in before, it will be a nig

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix new/edit pool dialogs for ja locale

2012-11-29 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix new/edit pool dialogs for ja locale .. webadmin: Fix new/edit pool dialogs for ja locale - Change the layout of some components in the new &

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix new/edit pool dialogs for ja locale

2012-11-29 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Fix new/edit pool dialogs for ja locale .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9364 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix new/edit pool dialogs for ja locale

2012-11-29 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Fix new/edit pool dialogs for ja locale .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9364 To unsubscrib

[Engine-patches] Change in ovirt-iso-uploader[master]: cleanup: code warning by pyflakes

2012-11-29 Thread kroberts
Keith Robertson has submitted this change and it was merged. Change subject: cleanup: code warning by pyflakes .. cleanup: code warning by pyflakes Change-Id: I012880df9e9d6b81b52cf311c24385342fe956c6 Signed-off-by: Alon Bar-Le

[Engine-patches] Change in ovirt-iso-uploader[master]: cleanup: style by pep8

2012-11-29 Thread kroberts
Keith Robertson has submitted this change and it was merged. Change subject: cleanup: style by pep8 .. cleanup: style by pep8 Change-Id: I0f5abd5dc6123937550300c132ffc1590a3e3851 Signed-off-by: Alon Bar-Lev --- M src/engine-is

[Engine-patches] Change in ovirt-iso-uploader[master]: cleanup: code warning by pyflakes

2012-11-29 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: cleanup: code warning by pyflakes .. Patch Set 1: Verified; Looks good to me, approved Thanks. -- To view, visit http://gerrit.ovirt.org/8853 To unsubscribe,

[Engine-patches] Change in ovirt-iso-uploader[master]: cleanup: style by pep8

2012-11-29 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: cleanup: style by pep8 .. Patch Set 1: Verified; Looks good to me, approved Looks good. Thank you. -- To view, visit http://gerrit.ovirt.org/8854 To unsubscr

[Engine-patches] Change in ovirt-host-deploy[master]: bridge: temporary workaround for firewalld behaviour

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: bridge: temporary workaround for firewalld behaviour .. bridge: temporary workaround for firewalld behaviour Currently, addNetwork just hangs if firewall

[Engine-patches] Change in ovirt-host-deploy[master]: bridge: temporary workaround for firewalld behaviour

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bridge: temporary workaround for firewalld behaviour .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9588 To unsubs

[Engine-patches] Change in ovirt-host-deploy[master]: bridge: temporary workaround for firewalld behaviour

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: bridge: temporary workaround for firewalld behaviour .. bridge: temporary workaround for firewalld behaviour Currently, addNetwork just hangs if firewalld is up

[Engine-patches] Change in otopi[master]: iptables: disable and stop firewalld to avoid conflict

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: iptables: disable and stop firewalld to avoid conflict .. iptables: disable and stop firewalld to avoid conflict Change-Id: I423846092615a25352539cb0abc1

[Engine-patches] Change in otopi[master]: iptables: disable and stop firewalld to avoid conflict

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: iptables: disable and stop firewalld to avoid conflict .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9587 To unsu

[Engine-patches] Change in ovirt-engine[master]: WIP: working CDI solution for backend

2012-11-29 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: WIP: working CDI solution for backend .. Patch Set 3: (2 inline comments) This is a really nice step in the right direction. Hope you continue with it. ...

[Engine-patches] Change in otopi[master]: iptables: disable and stop firewalld to avoid conflict

2012-11-29 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: iptables: disable and stop firewalld to avoid conflict .. iptables: disable and stop firewalld to avoid conflict Change-Id: I423846092615a25352539cb0abc19088408a

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce permissions on network

2012-11-29 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Introduce permissions on network .. Patch Set 2: (2 inline comments) File backend/manager/dbscripts/cr

[Engine-patches] Change in ovirt-engine[master]: engine: Require Permissions on Network

2012-11-29 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Require Permissions on Network .. Patch Set 2: (1 inline comment) File backend/manager/modules/bll/sr

[Engine-patches] Change in ovirt-engine[master]: engine: Require Permissions on Network

2012-11-29 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: engine: Require Permissions on Network .. Patch Set 2: (1 inline comment) File backend/manager/modules/bll/

[Engine-patches] Change in ovirt-engine[master]: tools : engine-manage-domains confirm delete domain

2012-11-29 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: tools : engine-manage-domains confirm delete domain .. tools : engine-manage-domains confirm delete domain When user deletes a domain using engine-manage-domains a

[Engine-patches] Change in ovirt-engine[master]: core: add NetworkLinking to AddVmInterfaceCommand

2012-11-29 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: add NetworkLinking to AddVmInterfaceCommand .. Patch Set 12: (2 inline comments) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: VM cleanup

2012-11-29 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: VM cleanup .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9480 To unsubscribe, visit http://ger

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2911 - Failure!

2012-11-29 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2911/ Build Number: 2911 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,530 - Changes Since

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2912 - Fixed!

2012-11-29 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2912/ Build Number: 2912 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,531 - Changes Since La

[Engine-patches] Change in ovirt-engine[master]: tools: Exposing ApplicationMode through engine-config

2012-11-29 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: tools: Exposing ApplicationMode through engine-config .. tools: Exposing ApplicationMode through engine-config ApplicationMode option is added to engine.config C

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix new/edit pool dialogs for ja locale

2012-11-29 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Fix new/edit pool dialogs for ja locale .. Patch Set 1: (2 inline comments) File frontend/webadmin/

[Engine-patches] Change in ovirt-engine[master]: webadmin: fixed initial focus in edit pool dialog

2012-11-29 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: fixed initial focus in edit pool dialog .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9571 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: allow editing VmInterface while the VM is running.

2012-11-29 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: core: allow editing VmInterface while the VM is running. .. core: allow editing VmInterface while the VM is running. NetworkLinking feature allows editig a VM wh

[Engine-patches] Change in ovirt-engine[master]: core: add NetworkLinking to UpdateVmInterfaceCommand (wip)

2012-11-29 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand (wip) .. core: add NetworkLinking to UpdateVmInterfaceCommand (wip) - messages- add bll errors related to "l

[Engine-patches] Change in ovirt-engine[master]: core: Remove SQL Server engine dialect

2012-11-29 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Remove SQL Server engine dialect .. core: Remove SQL Server engine dialect This is no longer needed. Change-Id: Ibdb0eb97dfe5554f2606e16b85705fbf51e571b

[Engine-patches] Change in ovirt-engine[master]: engine: DetachNetworkToVdsGroup for NetworkLinking (WIP)

2012-11-29 Thread msalem
Muli Salem has uploaded a new change for review. Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking (WIP) .. engine: DetachNetworkToVdsGroup for NetworkLinking (WIP) This patch makes sure NPEs are avoided due to

[Engine-patches] Change in ovirt-engine[master]: bootstrap: ovirt-node upgrade: create destination directory

2012-11-29 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: ovirt-node upgrade: create destination directory .. bootstrap: ovirt-node upgrade: create destination directory One would expect that there

[Engine-patches] Change in ovirt-engine[master]: bootstrap: ovirt-node upgrade: create destination directory

2012-11-29 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: bootstrap: ovirt-node upgrade: create destination directory .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9524

[Engine-patches] Change in ovirt-engine[master]: frontend: VM template change shouldn't change selected clust...

2012-11-29 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: VM template change shouldn't change selected cluster .. frontend: VM template change shouldn't change selected cluster Changing VM template us

[Engine-patches] Change in ovirt-engine[master]: frontend: VM template change shouldn't change selected clust...

2012-11-29 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: frontend: VM template change shouldn't change selected cluster .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9512 To unsub

[Engine-patches] Change in ovirt-engine[master]: frontend: VM template change shouldn't change selected clust...

2012-11-29 Thread lspevak
Libor Spevak has posted comments on this change. Change subject: frontend: VM template change shouldn't change selected cluster .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9512 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: bootstrap: ovirt-node upgrade: create destination directory

2012-11-29 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: bootstrap: ovirt-node upgrade: create destination directory .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9524

[Engine-patches] Change in ovirt-engine[master]: core: VM cleanup

2012-11-29 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: core: VM cleanup .. Patch Set 5: > In the old WPF days, we needed some compatibility, so changes such as- > isAutoStartup <= getauto_startup > were blocked. This

[Engine-patches] Change in ovirt-engine[master]: core: Remove PGHack

2012-11-29 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Remove PGHack .. Patch Set 1: I can't find any reference to this class in the codebase, so I think it is no longer needed. What do you think Eli, is it s

[Engine-patches] Change in ovirt-engine[master]: core: Remove PGHack

2012-11-29 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Remove PGHack .. core: Remove PGHack This is no longer needed. Change-Id: Id3ebd70516f427172ad206ad204ac95ec2a5a29f Signed-off-by: Juan Hernandez --- D

[Engine-patches] Change in ovirt-engine[master]: bootstrap: ovirt-node upgrade: create destination directory

2012-11-29 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: bootstrap: ovirt-node upgrade: create destination directory .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce permissions on network

2012-11-29 Thread msalem
Muli Salem has posted comments on this change. Change subject: engine: Introduce permissions on network .. Patch Set 2: (2 inline comments) File backend/manager/dbscripts/cre

[Engine-patches] Change in ovirt-engine[master]: core: add NetworkLinking to AddVmTemplateCommand

2012-11-29 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: core: add NetworkLinking to AddVmTemplateCommand .. core: add NetworkLinking to AddVmTemplateCommand isLinked property on VmNetworkInterface should also be save

[Engine-patches] Change in ovirt-engine[master]: core: add NetworkLinking to ChangeVMClusterCommand

2012-11-29 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: core: add NetworkLinking to ChangeVMClusterCommand .. core: add NetworkLinking to ChangeVMClusterCommand When chaning the VM Cluster- if the new Cluster doesn't

[Engine-patches] Change in ovirt-engine[master]: frontend: VM template change shouldn't change selected clust...

2012-11-29 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: frontend: VM template change shouldn't change selected cluster .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9512 To unsub

[Engine-patches] Change in ovirt-engine[master]: engine: Removing UpdateSpmHostNameVDSCommand class

2012-11-29 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Removing UpdateSpmHostNameVDSCommand class .. Patch Set 1: are you sure host_name cannot be updated? even with rest api? (== is there a canDoAction to bl

[Engine-patches] Change in ovirt-engine[master]: core:WIP: introducing OvfAutoUpdate

2012-11-29 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core:WIP: introducing OvfAutoUpdate .. Patch Set 10: (20 inline comments) File backend/manager/dbscripts/crea

[Engine-patches] Change in ovirt-engine[master]: webadmin: Hide VMs, Templates tab for gluster-only cluster

2012-11-29 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: Hide VMs,Templates tab for gluster-only cluster .. webadmin: Hide VMs,Templates tab for gluster-only cluster Virtual Machines and Templates tabs will no

[Engine-patches] Change in ovirt-engine[master]: engine: Ordering Networks by Name (#855886)

2012-11-29 Thread msalem
Muli Salem has uploaded a new change for review. Change subject: engine: Ordering Networks by Name (#855886) .. engine: Ordering Networks by Name (#855886) This patch changes the underlying query of NetworkDAO.getAllForCluster t

[Engine-patches] Change in ovirt-engine[master]: core: adding engine Maintenance and Prepare mode.

2012-11-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: adding engine Maintenance and Prepare mode. .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9568 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: engine: Removing UpdateSpmHostNameVDSCommand class

2012-11-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing UpdateSpmHostNameVDSCommand class .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9572 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: engine: Removing UpdateSpmHostNameVDSCommand class

2012-11-29 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Removing UpdateSpmHostNameVDSCommand class .. engine: Removing UpdateSpmHostNameVDSCommand class The following command contains a potential bug and als

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2909 - Still Failing!

2012-11-29 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2909/ Build Number: 2909 Build Status: Still Failing Triggered By: Started by upstream project "ovirt_engine" build number 3,528 - Changes

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2910 - Fixed!

2012-11-29 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2910/ Build Number: 2910 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,529 - Changes Since La

[Engine-patches] Change in ovirt-engine[master]: engine: VM Linux Boot options aren't parsing properly

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: VM Linux Boot options aren't parsing properly .. Patch Set 3: Einav - pls see the correspondence here and share your mind about trimming user input vs. dis

[Engine-patches] Change in ovirt-engine[master]: engine: VM Linux Boot options aren't parsing properly

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: VM Linux Boot options aren't parsing properly .. Patch Set 3: IMHO trimming user input isn't a trick. i'm adding Einav which is the UX principal to help us

[Engine-patches] Change in ovirt-engine[master]: webadmin: fixed initial focus in edit pool dialog

2012-11-29 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: fixed initial focus in edit pool dialog .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9571 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: webadmin: fixed initial focus in edit pool dialog

2012-11-29 Thread ahadas
Arik Hadas has restored this change. Change subject: webadmin: fixed initial focus in edit pool dialog .. Patch Set 1: Restored -- To view, visit http://gerrit.ovirt.org/9571 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: webadmin: fixed initial focus in edit pool dialog

2012-11-29 Thread ahadas
Arik Hadas has abandoned this change. Change subject: webadmin: fixed initial focus in edit pool dialog .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/9571 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: restapi: Extend block domain - override_luns

2012-11-29 Thread derez
Daniel Erez has posted comments on this change. Change subject: restapi: Extend block domain - override_luns .. Patch Set 1: (1 inline comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: webadmin: fixed initial focus in edit pool dialog

2012-11-29 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: fixed initial focus in edit pool dialog .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9571 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: webadmin: fixed initial focus in edit pool dialog

2012-11-29 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: webadmin: fixed initial focus in edit pool dialog .. webadmin: fixed initial focus in edit pool dialog The name textbox is the default component to get the initial

[Engine-patches] Change in ovirt-engine[master]: core: Add Windows 8/2012 to VM OS list

2012-11-29 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add Windows 8/2012 to VM OS list .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9530 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: RFE: allow to define deletion protection per vm

2012-11-29 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: RFE: allow to define deletion protection per vm .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/94

[Engine-patches] Change in ovirt-engine[master]: core: Add Intel Haswell model

2012-11-29 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: Add Intel Haswell model .. core: Add Intel Haswell model Adding Intel Haswell model to the engine's config Change-Id: I269a041227453fb3af11ce82e0db96

[Engine-patches] Change in ovirt-engine[master]: core: Add Intel Haswell model

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Add Intel Haswell model .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9392 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: add Opteron G5 model

2012-11-29 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: add Opteron G5 model .. core: add Opteron G5 model Adding AMD Opteron G5 model to the engine's config Change-Id: I6eb396a88898924459e6ba5ff58356adddc

[Engine-patches] Change in ovirt-engine[master]: core: add Opteron G5 model

2012-11-29 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: add Opteron G5 model .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9389 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Add Intel Haswel model

2012-11-29 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Add Intel Haswel model .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9392 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: Add Intel Haswel model

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Add Intel Haswel model .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/9392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-M

[Engine-patches] Change in ovirt-engine[master]: core: add Opteron G5 model

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: add Opteron G5 model .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/9389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Mes

[Engine-patches] Change in ovirt-engine[master]: engine: Internal VmNic Information (WIP)

2012-11-29 Thread msalem
Muli Salem has posted comments on this change. Change subject: engine: Internal VmNic Information (WIP) .. Patch Set 2: (13 inline comments) File backend/manager/dbscripts/cr

[Engine-patches] Change in ovirt-engine[master]: core: remove unneeded reflection use in SyntaxChecker

2012-11-29 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: remove unneeded reflection use in SyntaxChecker .. core: remove unneeded reflection use in SyntaxChecker Using the built-in valueOf method of Enum ins

[Engine-patches] Change in ovirt-engine[master]: core: remove unneeded reflection use in SyntaxChecker

2012-11-29 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: remove unneeded reflection use in SyntaxChecker .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9461 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: remove unneeded reflection use in SyntaxChecker

2012-11-29 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: remove unneeded reflection use in SyntaxChecker .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9461 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: adding engine Maintenance and Prepare mode.

2012-11-29 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: adding engine Maintenance and Prepare mode. .. Patch Set 3: Adding fix for queries -- To view, visit http://gerrit.ovirt.org/9568 To unsubscribe, visit http:

[Engine-patches] Change in samples-portals[master]: python: rename connect buttons to launch

2012-11-29 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: python: rename connect buttons to launch .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9521 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in samples-portals[master]: java sample portal: first commit

2012-11-29 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: java sample portal: first commit .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9520 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in samples-portals[master]: java sample portal: first commit

2012-11-29 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: java sample portal: first commit .. Patch Set 1: (4 inline comments) File java/javauserportal/src/main/java

[Engine-patches] Change in ovirt-engine[master]: engine: VM Linux Boot options aren't parsing properly

2012-11-29 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: engine: VM Linux Boot options aren't parsing properly .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/9550 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: adding engine Maintenance and Prepare mode.

2012-11-29 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: adding engine Maintenance and Prepare mode. .. core: adding engine Maintenance and Prepare mode. Support for that was already merged in http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Removing last host in status UP in pool

2012-11-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Removing last host in status UP in pool .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9566 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: engine: Removed useless checks at ConnectHostToStoragePoolSe...

2012-11-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removed useless checks at ConnectHostToStoragePoolServersCommand .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9567 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: engine: Removed useless checks at ConnectHostToStoragePoolSe...

2012-11-29 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Removed useless checks at ConnectHostToStoragePoolServersCommand .. engine: Removed useless checks at ConnectHostToStoragePoolServersCommand The follo

[Engine-patches] Change in ovirt-engine[master]: packaging: Remove overriden JBoss modules

2012-11-29 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Remove overriden JBoss modules .. Patch Set 2: Please don't merge this before version 7.1.1-9.3 of the jboss-as package is released. -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: Removing last host in status UP in pool

2012-11-29 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core: Removing last host in status UP in pool .. core: Removing last host in status UP in pool If host can not connect to storage it will be moved to Non-Opera

[Engine-patches] Change in ovirt-engine[master]: engine: VM Linux Boot options aren't parsing properly

2012-11-29 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: engine: VM Linux Boot options aren't parsing properly .. Patch Set 2: Verified @Roy: Concerning your comments: - trim before sending: i think we shouldn't play

  1   2   >