Moti Asayag has posted comments on this change.
Change subject: core: RunVm should send "linkState" to the vdsm.
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 480: VmDevice vmDevice,
Line 481: String nicModel,
Line 482: Version clusterVersion) {
Line 483: struct.add(VdsProperties.Type, vmDevice.getType());
Line 484: struct.add(VdsProperties.Device, vmDevice.getDevice());
shouldn't this change be executed only for 3.2 clusters and above ?
The linkState property shouldn't be part of any VDSM api earlier to 3.2.
Line 485: if (vmInterface.getNetworkName() != null) {
Line 486: struct.add(VdsProperties.network,
vmInterface.getNetworkName());
Line 487: }
Line 488: struct.add(VdsProperties.linkState, vmInterface.isLinked() ?
"up" : "down");
--
To view, visit http://gerrit.ovirt.org/9518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9805b18c364685a6533b89cfa31ae0575a00ea5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
