Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmInterfaceCommand
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
Line 198: }
Line 199:
Line 200: if (getParameters().getInterface().getNetworkName() != null) {
Line 201: // check that the exists in current cluster
Line 202: List<Network> networks =
DbFacade.getInstance().getNetworkDao().getAllForCluster(vm.getvds_group_id());
Please note that I've pushed a patch (haven't submitted yet) to reduce the
complexity in getting a Network within a specific cluster.
This code should be replaced with that api. See
http://gerrit.ovirt.org/#/c/9543/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAO.java
Line 203:
Line 204: Network interfaceNetwork =
LinqUtils.firstOrNull(networks, new Predicate<Network>() {
Line 205: @Override
Line 206: public boolean eval(Network network) {
--
To view, visit http://gerrit.ovirt.org/9447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I295dfb0af1bb7c6b2878f70344afd487aa2efbe1
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
