Roy Golan has posted comments on this change.

Change subject: core: VM cleanup
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 73:     public static void Init() {
Line 74:         mUpdateVmsStatic = new ObjectIdentityChecker(VmHandler.class,
Line 75:                 Arrays.asList(new String[] { "VM", "VmStatic", 
"VmDynamic" }), VMStatus.class);
Line 76: 
Line 77:         mUpdateVmsStatic.AddPermittedFields(new String[] { "vm_name", 
"description", "domain", "os", "osType",
need to update those as well.
Line 78:                 "creation_date", "num_of_monitors", 
"allowConsoleReconnect", "usb_policy", "is_auto_suspend",
Line 79:                 "auto_startup",
Line 80:                 "dedicated_vm_for_vds", "default_display_type", 
"priority", "default_boot_sequence", "initrd_url",
Line 81:                 "kernel_url", "kernel_params", "migrationSupport", 
"minAllocatedMem", "quotaId", "quotaName",


--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42da374a6929eae9be1880b6948d9218627b6c4f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to