Moti Asayag has posted comments on this change.

Change subject: engine: Introduce permissions on network
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File backend/manager/dbscripts/create_functions.sql
Line 304:             SELECT v_entity_id AS id;
Line 305: 
Line 306:       WHEN v_entity_type = 20 THEN -- Network
Line 307: 
Line 308:         SELECT INTO v_storage_pool_id
it looks ok to me.
Line 309:                     network.storage_pool_id
Line 310:         FROM network
Line 311:         WHERE network.id = v_entity_id;
Line 312: 


....................................................
File backend/manager/dbscripts/upgrade/03_02_0010_delete_permissions_on_vnic.sql
Line 1: -- Delete permissions if were given for VmNetworkInterface as
Line 2: -- it being removed from the entities hierarchy
Done
Line 3: 


--
To view, visit http://gerrit.ovirt.org/9533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If25d943cc3b7256b86a8c53ce8d37bb3b928521b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to