Yair Zaslavsky has uploaded a new change for review.
Change subject: core: VmPropertiesUtils should be initialized via StartupBean
..
core: VmPropertiesUtils should be initialized via StartupBean
This patch fixes VmPropertiesUti
Yair Zaslavsky has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 3:
Regarding's Eli comment about UI part -
I think Yaniv should separate API and UI to diff
Itamar Heim has posted comments on this change.
Change subject: core: add Opteron G5 model
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
nx flag validation is a must
..
Itamar Heim has posted comments on this change.
Change subject: core: Add Intell Haswel model
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
not validating nx would cause live migrations to fail
Itamar Heim has posted comments on this change.
Change subject: restapi: RFE: allow to define deletion protection per vm
..
Patch Set 1:
s/prevent_deletion/delete_protection/ ?
--
To view, visit http://gerrit.ovirt.org/9408
To
Itamar Heim has posted comments on this change.
Change subject: core: RFE: allow to define deletion protection per vm
..
Patch Set 1: (2 inline comments)
Commit Message
Line
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Create /usr/lib in the Makefile
..
Patch Set 1:
BTW: make PREFIX= should still install systemd artifacts at the correct
location...
Now I do 1+1 and
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (4 inline comments)
...
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Create /usr/lib in the Makefile
..
Patch Set 1:
Well, it is not exactly libdir... but as systemd forces /lib to point to
/usr/lib I guess it is OK.
H
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 3:
I don't understand why we need to run as root... systemd supports running under
specific user...
Juan Hernandez has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 3: Verified
The previous patch set had a problem with the setting on the nofile limit, it
is fixe
Juan Hernandez has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 2: Verified
Verified building and installing new RPMs, running engine-setup and
starting/stopping
Juan Hernandez has posted comments on this change.
Change subject: packaging: Create /usr/lib in the Makefile
..
Patch Set 1: Verified
Verified running the following:
make PREFIX=/tmp/ovirt install_without_maven
It works co
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Create /usr/lib in the Makefile
..
packaging: Create /usr/lib in the Makefile
Otherwise make PREFIX=/whatever fails.
Change-Id: I8f378d7397f1b45497
Juan Hernandez has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 1: (1 inline comment)
File Makefile
Line 388:
Juan Hernandez has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 2:
Sorry, I uploaded the wrong change in patch set 1, disregard it please, patch
set 2 is the thi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Replace /usr/lib with $(DATAROOT_DIR)
..
Patch Set 1: (1 inline comment)
File Makefile
Line 388:
Juan Hernandez has posted comments on this change.
Change subject: packaging: Replace /usr/lib with $(DATAROOT_DIR)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9426
To unsubscribe, visit http://gerrit.ovi
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Replace /usr/lib with $(DATAROOT_DIR)
..
packaging: Replace /usr/lib with $(DATAROOT_DIR)
Otherwise make PREFIX=/whatever fails.
Change-Id: I3a2b89
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Use configuration to generate paths
..
packaging: Use configuration to generate paths
The service start/stop script still had some paths har
Juan Hernandez has posted comments on this change.
Change subject: packaging: Use configuration to generate paths
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view
Juan Hernandez has posted comments on this change.
Change subject: packaging: Use configuration to generate paths
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8297
To unsubscrib
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/
Juan Hernandez has posted comments on this change.
Change subject: core: Fix a typo in dbscripts
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Juan Hernandez has uploaded a new change for review.
Change subject: core: Fix a typo in dbscripts
..
core: Fix a typo in dbscripts
There is an small typo in the engine-db-isntall.sh script, it puts line
breaks in the middle of
Eli Mesika has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 3: (1 inline comment)
UI part is still missing from this patch, where this information is displa
Muli Salem has uploaded a new change for review.
Change subject: engine: Internal VmNic Information (WIP)
..
engine: Internal VmNic Information (WIP)
This patch adds the new VmInterfaceDynamic entity, to represent
the internal i
Eli Mesika has posted comments on this change.
Change subject: core: Use .pgpass from home in dev env
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9417
To unsubscribe, visit http://gerrit
Eli Mesika has uploaded a new change for review.
Change subject: core: Adding LIO iSCSI target as ... (#879272)
..
core: Adding LIO iSCSI target as ... (#879272)
Adding LIO iSCSI target as storage fails because of LUN ID size be
Allon Mureinik has posted comments on this change.
Change subject: core: skip quota for flows with no storage pool
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9410
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: skip quota for flows with no storage pool
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9410
T
Allon Mureinik has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Allon Mureinik has posted comments on this change.
Change subject: core: Quota Dependency Test + RemoveSnapshot fix
..
Patch Set 1: (2 inline comments)
File
backend/manager/
Daniel Paikov has posted comments on this change.
Change subject: core: [WIP] Remove global lock on SPM calls from engine side
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9298
To unsubscribe, visit http:/
Vinzenz Feenstra has posted comments on this change.
Change subject: agent: Added APT package list support
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/8642
To unsubscribe, visit http://gerrit.ovirt.org/se
Juan Hernandez has posted comments on this change.
Change subject: core: Use .pgpass from home in dev env
..
Patch Set 1: Verified
Verified creating the database in de dev environment when the
/etc/ovirt-engine/.pgpass doesn't
Juan Hernandez has uploaded a new change for review.
Change subject: core: Use .pgpass from home in dev env
..
core: Use .pgpass from home in dev env
We use the .pgpass file from /etc/ovirt-engine in production
environments, but
ofri masad has posted comments on this change.
Change subject: core: Quota Dependency Test + RemoveSnapshot fix
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9413
To unsubscribe, visit http://gerrit.ovirt.o
Michal Skrivanek has posted comments on this change.
Change subject: core: validate max lun disk attachment
..
Patch Set 2: Looks good to me, but someone else must approve
and where is the limit actually coming from anyway?
--
Juan Hernandez has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
I think that maybe a better way to integrate additional authentication
Michael Kublin has posted comments on this change.
Change subject: engine: Replaced quartz job to thread job at MigrateVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9416
To unsubscribe, visit htt
Michael Kublin has uploaded a new change for review.
Change subject: engine: Replaced quartz job to thread job at MigrateVDSCommand
..
engine: Replaced quartz job to thread job at MigrateVDSCommand
Because of we have more thread
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Change "Active" vnic to "Plugged"
..
webadmin: Change "Active" vnic to "Plugged"
- VmInterface Dialog -change Activate checkobox to radio button-
"Card
Juan Hernandez has uploaded a new change for review.
Change subject: core: Loadable auth providers
..
core: Loadable auth providers
Currently the different types of authentication providers is hard coded
in the LdapFactory class
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2779/
Build Number: 2779
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,497
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2778/
Build Number: 2778
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,496
-
Changes Sin
ofri masad has abandoned this change.
Change subject: core: Fix cant add LUN disk bug
..
Patch Set 1: Abandoned
fixed in Change-Id: Ie468db3709522653cd93c338564592e2ba439c4a
--
To view, visit http://gerrit.ovirt.org/9411
To un
ofri masad has posted comments on this change.
Change subject: core: skip quota for flows with no storage pool
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9410
To un
ofri masad has uploaded a new change for review.
Change subject: core: Quota Dependency Test + RemoveSnapshot fix
..
core: Quota Dependency Test + RemoveSnapshot fix
Added a test that checks that is VdcActionType is defined quot
Allon Mureinik has posted comments on this change.
Change subject: core: MockEJBStrategyRule
..
Patch Set 1:
mkublin - the entire point of itsest is to run with embedded JBoss (instead of
mocking stuff).
IMHO - it's all dead
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 3: (1 inline comment)
Implemented new remove method which accepts Action and deleg
Shireesh Anjal has posted comments on this change.
Change subject: engine: Passwordless ssh status query
..
Patch Set 3:
Alon, to answer your question, SshConnectionFailed and its friends are error
enums mapped to correspondin
Shireesh Anjal has posted comments on this change.
Change subject: engine: Passwordless ssh status query
..
Patch Set 3: (5 inline comments)
File
backend/manager/modules/bll
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Gluster Peer Detach bll command
..
engine: Gluster Peer Detach bll command
Includes following related to the command for "gluster peer detach"
-
Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9044
To unsubscribe, visit http://ger
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 8: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/9044
To unsubscribe, visit http://gerrit.
ofri masad has posted comments on this change.
Change subject: core: Fix cant add LUN disk bug
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
ofri masad has uploaded a new change for review.
Change subject: core: Fix cant add LUN disk bug
..
core: Fix cant add LUN disk bug
Adding LUN disk was causing InvalidQuotaParameterException
because the Quota checks requires sto
Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9044
To unsubscribe, visit http://ger
Roy Golan has posted comments on this change.
Change subject: core: validate max lun disk attachment
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/
Yair Zaslavsky has submitted this change and it was merged.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
..
gluster: replace VdsInstallerSSH: with the SSHDialog
VdsInstallerSSH is going to retire.
Bug-U
Yair Zaslavsky has posted comments on this change.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
..
Patch Set 14: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9160
To uns
Michal Skrivanek has posted comments on this change.
Change subject: core: validate max lun disk attachment
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade
Cur
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 15: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
..
engine: Adding null check for VDS in NewGlusterServersQuery
In case of an empty cluster we
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 14: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Omer Frenkel has posted comments on this change.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9314
To unsubscri
Daniel Erez has posted comments on this change.
Change subject: core: Adding force extend support to extendVG
..
Patch Set 2: (1 inline comment)
Commit Message
Line 7: core:
Michael Kublin has posted comments on this change.
Change subject: core: MockEJBStrategyRule
..
Patch Set 1:
Now we have three overrides of EjbUtils , and two of them for tests? And we
really need JBOSS embedded for itest?
--
Roy Golan has uploaded a new change for review.
Change subject: core: skip quota for flows with no storage pool
..
core: skip quota for flows with no storage pool
Quota checks are being made based on a commands "quota dependency
Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: RFE: allow to define deletion protection
per vm
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9405
T
Frank Kobzik has posted comments on this change.
Change subject: webadmin,userportal: RFE: allow to define deletion protection
per vm
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9405
To unsubscribe, visi
Roy Golan has posted comments on this change.
Change subject: core: validate max lun disk attachment
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has uploaded a new change for review.
Change subject: core: validate max lun disk attachment
..
core: validate max lun disk attachment
The check for the limit of PCI addresses was missing when adding a lun
disk.
Chang
Frank Kobzik has posted comments on this change.
Change subject: core: RFE: allow to define deletion protection per vm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9404
To unsubscribe, visit http://gerrit.
Frank Kobzik has posted comments on this change.
Change subject: webadmin,userportal: RFE: allow to define deletion protection
per vm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9405
To unsubscribe, visi
Kanagaraj M has posted comments on this change.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
..
Patch Set 3: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/9314
To unsub
Frank Kobzik has uploaded a new change for review.
Change subject: restapi: RFE: allow to define deletion protection per vm
..
restapi: RFE: allow to define deletion protection per vm
This patch introduces protection from unwant
Omer Frenkel has posted comments on this change.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9314
To unsubscri
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
bootstrap: use LocalConfig for engine http host and port
This retires the VdcBootStrapUrl,
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9368
To
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9368
To
Frank Kobzik has uploaded a new change for review.
Change subject: webadmin,userportal: RFE: allow to define deletion protection
per vm
..
webadmin,userportal: RFE: allow to define deletion protection per vm
This patch introduc
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (1 inline comment)
Yair Zaslavsky has posted comments on this change.
Change subject: tools: some manage domains cleanup
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9350
To unsubscribe, visit htt
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
tools: Don't ask for password, before DNS SRV records are returned.
This patch
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: some manage domains cleanup
..
tools: some manage domains cleanup
During working on a bug, I discovered we have
an enum we no longer use, so I r
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.
Frank Kobzik has uploaded a new change for review.
Change subject: core: RFE: allow to define deletion protection per vm
..
core: RFE: allow to define deletion protection per vm
This patch introduces protection from unwanted del
Muli Salem has submitted this change and it was merged.
Change subject: engine: Extract Vlan Id Validation (#871864)
..
engine: Extract Vlan Id Validation (#871864)
This patch extracts repetitive code to the mutual parent
class
Muli Salem has posted comments on this change.
Change subject: engine: Extract Vlan Id Validation (#871864)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9312
To unsubscribe, vis
Moti Asayag has posted comments on this change.
Change subject: engine: Extract Vlan Id Validation (#871864)
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
Fi
Shireesh Anjal has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (1 inline comment)
...
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Fixing localization issues in Volume dialog
..
webadmin: Fixing localization issues in Volume dialog
Button texts were not localized in Create Volume an
Gilad Chaplik has posted comments on this change.
Change subject: core: remove unused private method from
CommonVmPoolWithVmsCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9393
To
Allon Mureinik has posted comments on this change.
Change subject: core: MockEJBStrategyRule
..
Patch Set 1:
mkublin - JBossEmbeddedEJBUtilsStrategy is used for running itests against a
real embedded JBoss intanse, which I di
Vered Volansky has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
Maor Lipchuk has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/
99 matches
Mail list logo
