Alon Bar-Lev has posted comments on this change. Change subject: packaging: Replace /usr/lib with $(DATAROOT_DIR) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File Makefile Line 388: install -m 644 packaging/fedora/engine-service-logging.properties.in $(DESTDIR)$(DATA_DIR)/service Line 389: install -m 755 packaging/fedora/engine-service.py $(DESTDIR)$(DATA_DIR)/service Line 390: install -m 644 packaging/fedora/engine-service.sysconfig $(DESTDIR)$(SYSCONF_DIR)/sysconfig/ovirt-engine Line 391: install -m 644 packaging/fedora/engine-service.limits $(DESTDIR)$(SYSCONF_DIR)/security/limits.d/10-$(ENGINE_NAME).conf Line 392: install -m 644 packaging/fedora/engine-service.systemd $(DESTDIR)$(DATAROOT_DIR)/systemd/system/ovirt-engine.service I don't understand.... systemd stuff is in /usr/lib... how will DATAROOT_DIR work? Line 393: Line 394: # Install the links: Line 395: ln -s $(DATA_DIR)/service/engine-service.py $(DESTDIR)$(BIN_DIR)/engine-service -- To view, visit http://gerrit.ovirt.org/9426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a2b89aa3a32fa93bc19b2be9511bd97e5ea617e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
