Moti Asayag has posted comments on this change.
Change subject: engine: Extract Vlan Id Validation (#871864)
......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/NetworkCommon.java
Line 91: }
Line 92: }
Line 93: return true;
Line 94: }
Line 95:
Please consider a follower patch to replace the vlan-id range validation with a
validation on the Network entity using the hibernate-validation.
Line 96: private boolean isVlanInRange(int vlanId) {
Line 97: return (vlanId >= 0 && vlanId <= 4095);
Line 98: }
--
To view, visit http://gerrit.ovirt.org/9312
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
