Roy Golan has uploaded a new change for review. Change subject: core: validate max lun disk attachment ......................................................................
core: validate max lun disk attachment The check for the limit of PCI addresses was missing when adding a lun disk. Change-Id: I4a82b3ed85c89beb8df70315ad457f54b366d69d Bug-Url: http://bugzilla.redhat.com/876127 Signed-off-by: Roy Golan <rgo...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/9409/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java index 4c09539..4519972 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java @@ -117,7 +117,8 @@ if (getDiskLunMapDao().getDiskIdByLunId(lun.getLUN_id()) != null) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_IS_ALREADY_IN_USE); } - return true; + + return isDiskPassPciAndIdeLimit(getParameters().getDiskInfo()); } private boolean checkIfImageDiskCanBeAdded(VM vm) { -- To view, visit http://gerrit.ovirt.org/9409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4a82b3ed85c89beb8df70315ad457f54b366d69d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
