Allon Mureinik has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 202: log.warnFormat("Wasn't able to live snpashot due to error:
{0}. VM will still be configured to the new created snapshot",
Line 203: ExceptionUtils.getMessage(e));
Line 204: AuditLogableBase logable = new AuditLogableBase();
Line 205: logable.AddCustomValue("SnapshotName", getSnapshotName());
Line 206: logable.AddCustomValue("VmName", getVmName());
why not set these attributes on the command itself?
Line 207: AuditLogDirector.log(logable,
AuditLogType.USER_CREATE_LIVE_SNAPSHOT_FINISHED_FAILURE);
Line 208: }
Line 209:
Line 210: /**
--
To view, visit http://gerrit.ovirt.org/9390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
