Oved Ourfali has submitted this change and it was merged.
Change subject: userportal: SearchResultsLimit race condition (#853904)
..
userportal: SearchResultsLimit race condition (#853904)
https://bugzilla.redhat.com/853904
Se
Oved Ourfali has posted comments on this change.
Change subject: userportal: SearchResultsLimit race condition (#853904)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8181
To uns
Tomas Jelinek has posted comments on this change.
Change subject: userportal: SearchResultsLimit race condition (#853904)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8181
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: core: Extracted VmValidator
..
Patch Set 4: Looks good to me, approved
look ok - except that this ValidationResult is a useless wrapper to
VdcBllMessage. we can act
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Using editable combo for volume option key
..
webadmin: Using editable combo for volume option key
In the Volume option dialog, the keys will be shown i
Oved Ourfali has posted comments on this change.
Change subject: tools: Handling add first/removing last domain (#858769)
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8178
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: SanStorageTargetToLunList FindBugs
..
webadmin: SanStorageTargetToLunList FindBugs
Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_
Daniel Erez has posted comments on this change.
Change subject: webadmin: SanStorageTargetToLunList FindBugs
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8177
To unsubscribe, v
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: SanStorageLunToTargetList FindBugs
..
webadmin: SanStorageLunToTargetList FindBugs
Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BE
Daniel Erez has posted comments on this change.
Change subject: webadmin: SanStorageLunToTargetList FindBugs
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8176
To unsubscribe, vi
Daniel Erez has uploaded a new change for review.
Change subject: userportal: SearchResultsLimit race condition (#853904)
..
userportal: SearchResultsLimit race condition (#853904)
https://bugzilla.redhat.com/853904
SearchableL
Daniel Erez has submitted this change and it was merged.
Change subject: Revert "userportal: SearchResultsLimit race condition (#853904)"
..
Revert "userportal: SearchResultsLimit race condition (#853904)"
This reverts commit 0
Daniel Erez has posted comments on this change.
Change subject: Revert "userportal: SearchResultsLimit race condition (#853904)"
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/818
Daniel Erez has posted comments on this change.
Change subject: Revert "userportal: SearchResultsLimit race condition (#853904)"
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/818
Daniel Erez has reverted this change.
Change subject: Revert "userportal: SearchResultsLimit race condition (#853904)"
..
Patch Set 2: Reverted
This patchset was reverted in change: Iee499669af30b4b620b9fa9bd86b775b4f9e1eee
--
Yair Zaslavsky has uploaded a new change for review.
Change subject: tools: Handling add first/removing last domain (#858769)
..
tools: Handling add first/removing last domain (#858769)
https://bugzilla.redhat.com/858769
This p
Moran Goldboim has posted comments on this change.
Change subject: tools: Don't print help on error (BZ858968)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8090
To un
Ayal Baron has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/bl
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 4: Verified
OK, a new dependency is added "cvs".
Now we parse correctly most of the outputs,
Allon Mureinik has posted comments on this change.
Change subject: webadmin: SanStorageTargetToLunList FindBugs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8177
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: webadmin: SanStorageLunToTargetList FindBugs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8176
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: SanStorageTargetToLunList FindBugs
..
webadmin: SanStorageTargetToLunList FindBugs
Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_
Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: SanStorageLunToTargetList FindBugs
..
webadmin: SanStorageLunToTargetList FindBugs
Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: cleanup: remove unused isDBUp, execSqlCommand
..
Patch Set 1: Verified
Well, verified as in tested no exceptions, and greping usage...
--
To view, vis
Allon Mureinik has posted comments on this change.
Change subject: engine:Validate maximum number of hosts in DC.(#771699)
..
Patch Set 12: Looks good to me, but someone else must approve
(1 inline comment)
...
Allon Mureinik has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7204
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: Forbid attaching a locked disk to a VM (#856137)
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
see inline, minor issues
Federico Simoncelli has abandoned this change.
Change subject: Use the real parent command for getParametersForTask
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/8025
To unsubscribe, visit http://gerrit.ov
Michael Kublin has posted comments on this change.
Change subject: core: replace Date with long for time variable
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7245
To unsubscribe, visit h
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: fix in error message (#853704)
..
core: fix in error message (#853704)
Previous patch changed the message, but there was a typo there.
Fixing the
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix in error message (#853704)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8173
To unsubscribe, visit h
Oved Ourfali has uploaded a new change for review.
Change subject: core: fix in error message (#853704)
..
core: fix in error message (#853704)
Previous patch changed the message, but there was a typo there.
Fixing the message.
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated names of etl and notifier services
..
packaging: Updated names of etl and notifier services
Change-Id: Icea5953c7d233b068056b75955f440b6dd6df32
Allon Mureinik has posted comments on this change.
Change subject: core: VmMigrateDiskoComplete VDS command
..
Patch Set 2: (1 inline comment)
Commit Message
Line 3: AuthorDa
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 5: Fails
(1 inline comment)
Frankly, this looks like a considerably less elegant solution to me, but a
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: using pg_dump --column-inserts ...(#858643)
..
core: using pg_dump --column-inserts ...(#858643)
using pg_dump --column-inserts slows down the re
Yair Zaslavsky has posted comments on this change.
Change subject: core: using pg_dump --column-inserts ...(#858643)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8134
To unsubscribe, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: core: using pg_dump --column-inserts ...(#858643)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8134
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: core: using pg_dump --column-inserts ...(#858643)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8134
To unsubscribe, visi
Eli Mesika has submitted this change and it was merged.
Change subject: core: task manager cache is not cleared..(#854308)
..
core: task manager cache is not cleared..(#854308)
task manager cache is not cleared after getting er
Eli Mesika has posted comments on this change.
Change subject: core: task manager cache is not cleared..(#854308)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8161
To unsubscrib
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: defend against disconnected mode when no proxy cached
..
sdk: defend against disconnected mode when no proxy cached
Change-Id: Id2349669dcbd26b32d877d9
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: remove unused filter_header argument
..
sdk: remove unused filter_header argument
Change-Id: I8f99f1acbb434ee05c26a9e50c563b9e113fd923
Signed-off-by: M
Liron Aravot has posted comments on this change.
Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the
same pool(#845838)
..
Patch Set 2: (1 inline comment)
...
Michael Kublin has posted comments on this change.
Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the
same pool(#845838)
..
Patch Set 2: (1 inline comment)
.
Roy Golan has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7204
To unsubscribe, visit htt
Juan Hernandez has posted comments on this change.
Change subject: packaging: updated handling of pgpass file between versions
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: Stop->Power Off (#857327)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8043
To unsubscribe, visit ht
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Make HA consistant in VM and template tabs
..
webadmin: Make HA consistant in VM and template tabs
Problems:
* Inconsistent display of the hig
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Make HA consistant in VM and template tabs
..
Patch Set 2: Verified; Looks good to me, approved
rebased & verified
--
To view, visit http://gerrit.ovi
Oved Ourfali has submitted this change and it was merged.
Change subject: core: spm and master domain maintenance actions cause wrong
error (#853704)
..
core: spm and master domain maintenance actions cause wrong error (#853704
Oved Ourfali has posted comments on this change.
Change subject: core: spm and master domain maintenance actions cause wrong
error (#853704)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.
Oved Ourfali has posted comments on this change.
Change subject: core: spm and master domain maintenance actions cause wrong
error (#853704)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8166
To unsubscrib
Asaf Shakarchi has uploaded a new change for review.
Change subject: core: Forbid attaching a locked disk to a VM (#856137)
..
core: Forbid attaching a locked disk to a VM (#856137)
- Forbid attaching a locked disk to a VM.
- Re
Michael Kublin has posted comments on this change.
Change subject: core: spm and master domain maintenance actions cause wrong
error (#853704)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.or
Gilad Chaplik has posted comments on this change.
Change subject: core: Renamed Refresh to refreshModel
..
Patch Set 4: Verified; Looks good to me, approved
rebased & verified
--
To view, visit http://gerrit.ovirt.org/8111
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Renamed Refresh to refreshModel
..
core: Renamed Refresh to refreshModel
Fixes FindBugs issues -
1. VERY confusing to have methods
org.ovirt.eng
Oved Ourfali has uploaded a new change for review.
Change subject: core: spm and master domain maintenance actions cause wrong
error (#853704)
..
core: spm and master domain maintenance actions cause wrong error (#853704)
When
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: pass HA value to template from vm
..
webadmin: pass HA value to template from vm
Problems:
* When creating tamplate from vm the high availabil
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: pass HA value to template from vm
..
Patch Set 5: Verified; Looks good to me, approved
reviewed
--
To view, visit http://gerrit.ovirt.org/8154
To unsu
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Allow attaching v2 domains for v3 pool (#856166)
..
webadmin: Allow attaching v2 domains for v3 pool (#856166)
https://bugzilla.redhat.com/85
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Allow attaching v2 domains for v3 pool (#856166)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8091
T
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal: SearchResultsLimit race condition (#853904)
..
userportal: SearchResultsLimit race condition (#853904)
https://bugzilla.redhat.com/853904
Se
Oved Ourfali has posted comments on this change.
Change subject: userportal: SearchResultsLimit race condition (#853904)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8132
To uns
Muli Salem has submitted this change and it was merged.
Change subject: core: Proccessing Vdsm Error Code to API (#858719)
..
core: Proccessing Vdsm Error Code to API (#858719)
https://bugzilla.redhat.com/858719
Propagating er
Muli Salem has posted comments on this change.
Change subject: core: Proccessing Vdsm Error Code to API (#858719)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8151
To unsubscrib
Daniel Erez has posted comments on this change.
Change subject: engine: Allow empty quota in audit mode (#855633)
..
Patch Set 2: Looks good to me, but someone else must approve
+1 on frontend
--
To view, visit http://gerrit.o
Eli Mesika has uploaded a new change for review.
Change subject: core: Cannot edit properties of running vms.
..
core: Cannot edit properties of running vms.
Cannot edit properties (that does not require guest reboot to take eff
Muli Salem has submitted this change and it was merged.
Change subject: core: AuditLog for Activate/Deactivate VmNic (#858719)
..
core: AuditLog for Activate/Deactivate VmNic (#858719)
https://bugzilla.redhat.com/858719
Adding
Muli Salem has posted comments on this change.
Change subject: core: AuditLog for Activate/Deactivate VmNic (#858719)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8152
To unsubs
Muli Salem has submitted this change and it was merged.
Change subject: core: Error Code Handling for AddVmNic (#858719)
..
core: Error Code Handling for AddVmNic (#858719)
https://bugzilla.redhat.com/858719
This patch makes s
Muli Salem has posted comments on this change.
Change subject: core: Error Code Handling for AddVmNic (#858719)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8150
To unsubscribe,
Ori Liel has posted comments on this change.
Change subject: sdk: allow persistent_auth via localhost
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8163
To unsubscribe
Daniel Erez has posted comments on this change.
Change subject: webadmin: import: validate quota in enforce mode (#855635)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8060
To unsubscribe
Noam Slomianko has posted comments on this change.
Change subject: webadmin: Make HA consistant in VM and template tabs
..
Patch Set 1: Verified
Seems to be the desired behavior
--
To view, visit http://gerrit.ovirt.org/8164
T
Daniel Erez has posted comments on this change.
Change subject: webadmin: import: storage drop down is empty (#856976)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8156
To unsubscribe, vi
Noam Slomianko has posted comments on this change.
Change subject: webadmin: pass HA value to template from vm
..
Patch Set 4: Verified
Split commit as suggested
--
To view, visit http://gerrit.ovirt.org/8154
To unsubscribe, v
Noam Slomianko has uploaded a new change for review.
Change subject: webadmin: Make HA consistant in VM and template tabs
..
webadmin: Make HA consistant in VM and template tabs
Problems:
* Inconsistent display of the high avail
Daniel Erez has posted comments on this change.
Change subject: webadmin: Allow attaching v2 domains for v3 pool (#856166)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8091
To unsubscribe
Doron Fediuck has posted comments on this change.
Change subject: engine: Allow empty quota in audit mode (#855633)
..
Patch Set 2:
Unitests?
--
To view, visit http://gerrit.ovirt.org/8059
To unsubscribe, visit http://gerrit.o
Moti Asayag has posted comments on this change.
Change subject: core: AuditLog for Activate/Deactivate VmNic (#858719)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8152
To unsubscribe, vi
Sharad Mishra has posted comments on this change.
Change subject: core: VmMigrateDiskoComplete VDS command
..
Patch Set 2: (1 inline comment)
Commit Message
Line 3: AuthorDat
Moti Asayag has posted comments on this change.
Change subject: core: Error Code Handling for AddVmNic (#858719)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8150
To unsubscribe, visit ht
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: allow persistent_auth via localhost
..
sdk: allow persistent_auth via localhost
Change-Id: If3df5b766cfcea48dcc5a9cfb266c55570e55234
Signed-off-by: Mic
Sharad Mishra has posted comments on this change.
Change subject: [WIP] tools: Refactor of EngineConfigLogic (#858769)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/81
Yair Zaslavsky has posted comments on this change.
Change subject: core: Proccessing Vdsm Error Code to API (#858719)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8151
To unsubscribe, vis
Tomas Jelinek has posted comments on this change.
Change subject: userportal: SearchResultsLimit race condition (#853904)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8132
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Now, you in correct direction, after
Michael Kublin has posted comments on this change.
Change subject: core: task manager cache is not cleared..(#854308)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8161
To unsubscribe, vis
Ori Liel has posted comments on this change.
Change subject: restapi: Schema API element - add min/max occurences
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8160
To unsubscrib
Eli Mesika has uploaded a new change for review.
Change subject: core: task manager cache is not cleared..(#854308)
..
core: task manager cache is not cleared..(#854308)
task manager cache is not cleared after getting error that
Michael Pasternak has posted comments on this change.
Change subject: restapi: Schema API element - add min/max occurences
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8160
To unsubscribe
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: pass HA value to template from vm
..
Patch Set 3:
I would first fix the bug (at VmListModel.java), and the other fixes can be
pushed in a separate pa
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 11: (1 inline comment)
File
frontend/webadmin/modul
Ori Liel has abandoned this change.
Change subject: restapi: schema add missing minOccurs, maxOccurs
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/8155
To unsubscribe, visit http://gerrit.ovirt.org/setting
Ori Liel has uploaded a new change for review.
Change subject: restapi: Schema API element - add min/max occurences
..
restapi: Schema API element - add min/max occurences
Change-Id: I1208d0ba3355fbde74cd43cac4fd444058943f1a
Sig
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/3102/
Build Number: 3102
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Changes
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: fix checkstyle in tests
..
core: fix checkstyle in tests
Adds NON-NLS to the tests
Change-Id: I91f931fd176d8c96b11a4ac2ec8c1ec0dbe0dcf5
Signed-o
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix checkstyle in tests
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8159
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix checkstyle in tests
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8159
To unsubscribe, visit http://g
1 - 100 of 168 matches
Mail list logo
