Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: SanStorageTargetToLunList FindBugs
......................................................................
webadmin: SanStorageTargetToLunList FindBugs
Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE.
The items variable is clearly not null here, since isEmpty() is
called on it beforehand, so the conditional statement can be safely
removed.
Change-Id: I645d6ce09a94d3a0d1d98e7514720c439e7c3492
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/8177/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
index e3ad40f..3425166 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
@@ -240,7 +240,7 @@
}
}, constants.serialSanStorage(), "120px"); //$NON-NLS-1$
- table.setRowData(items == null ? new ArrayList<LunModel>() : items);
+ table.setRowData(items);
table.edit(leafModel);
table.setWidth("100%", true); //$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/8177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I645d6ce09a94d3a0d1d98e7514720c439e7c3492
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
