Liron Aravot has posted comments on this change. Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the same pool(#845838) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java Line 54: } Line 55: Line 56: @Override Line 57: protected boolean canDoAction() { Line 58: boolean toReturn = false; avoid simultaneous reconstruct initiated by automatic processes and by user from gui. this lock prevents it and will allow user initiated reconstruct only if automatic reconstruct doesn't run at the moment to avoid race conditions. Line 59: if (IrsBrokerCommand.tryLockIrsProxyData(getStoragePool().getId())) { Line 60: try { Line 61: toReturn = performChecks(); Line 62: } catch (Exception e) { -- To view, visit http://gerrit.ovirt.org/7982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dfb227b014af602e5bd1ab952d7c543992aa0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches