Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fixing gluster volume CIFS export configuration
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8032
To unsubscribe
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fixing gluster volume CIFS export configuration
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8032
To unsubscribe
Selvasundaram has posted comments on this change.
Change subject: engine: Bll Query to fetch the newly added Gluster servers
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/7456
To unsubscribe, visit http://g
Sharad Mishra has posted comments on this change.
Change subject: core: Incorrect number of arguments passed to String.format in
VdsInstallerSSH
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8112
To unsubs
Sharad Mishra has posted comments on this change.
Change subject: engine: Remove unnecessary code and add check for NPE.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7916
To unsubscribe, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: core: Incorrect number of arguments passed to String.format in
VdsInstallerSSH
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Sharad Mishra has posted comments on this change.
Change subject: core: Incorrect number of arguments passed to String.format in
VdsInstallerSSH
..
Patch Set 1: (1 inline comment)
..
Alon Bar-Lev has posted comments on this change.
Change subject: core: Incorrect number of arguments passed to String.format in
VdsInstallerSSH
..
Patch Set 1: (1 inline comment)
...
Sharad Mishra has posted comments on this change.
Change subject: core: Incorrect number of arguments passed to String.format in
VdsInstallerSSH
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8112
To unsubs
Sharad Mishra has uploaded a new change for review.
Change subject: core: Incorrect number of arguments passed to String.format in
VdsInstallerSSH
..
core: Incorrect number of arguments passed to String.format in VdsInstallerSSH
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed xyzDAO to xyzDao in DbFacade.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8106
To unsubscribe, visit http://gerrit.ovirt.org
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed Refresh to refreshModel
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8111
To unsubscribe, visit http://gerrit.ovirt.org/setti
Sharad Mishra has posted comments on this change.
Change subject: core: Refactor getDiskDAO to getDiskDao
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8100
To unsubscribe, visit http://gerrit.ovirt.org/set
Sharad Mishra has posted comments on this change.
Change subject: core: Refactored roles to Role.
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/7229
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Itamar Heim has posted comments on this change.
Change subject: core: Renamed Refresh to refreshModel
..
Patch Set 1:
please fix comment to include findbug text rather than url.
thanks
--
To view, visit http://gerrit.ovirt.org
Sharad Mishra has uploaded a new change for review.
Change subject: core: Renamed Refresh to refreshModel
..
core: Renamed Refresh to refreshModel
Fixes FindBugs issues -
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2517
Keith Robertson has posted comments on this change.
Change subject: tools: Fix default port (BZ857481)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8006
To unsubscribe, visit ht
Keith Robertson has submitted this change and it was merged.
Change subject: tools: Fix default port (BZ857481)
..
tools: Fix default port (BZ857481)
Change-Id: Ice63ed76f3c5166ed5586ad8984709d7ff77e62c
Signed-off-by: Keith Rob
Keith Robertson has posted comments on this change.
Change subject: tools: Fix default port (BZ857128)
..
Patch Set 2: Verified; Looks good to me, approved
(1 inline comment)
...
Keith Robertson has submitted this change and it was merged.
Change subject: tools: Fix default port (BZ857128)
..
tools: Fix default port (BZ857128)
Change-Id: I1be2e0c2af8f6c0f05144323686ab84801b2aa45
Signed-off-by: Keith Rob
Michael Kublin has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 3: (1 inline comment)
File
backend/manager/module
Michael Kublin has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 3: I would prefer that you didn't submit this
Sorry, but these is a very bad design.
First of all, you
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: Run once dialog redesign (#852057)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
(1 inline comment)
Itamar Heim has posted comments on this change.
Change subject: core: Refactor getDiskDAO to getDiskDao
..
Patch Set 1:
please fix comment to have the findbugs text explaining the issue, rather than
url.
thanks
--
To view, vi
Itamar Heim has posted comments on this change.
Change subject: core: Renamed xyzDAO to xyzDao in DbFacade.
..
Patch Set 1:
please fix the comment to copy paste the description of the findbug issue
rather than the url, since t
Ricky Hopper has uploaded a new change for review.
Change subject: core: Add scan domain query
..
core: Add scan domain query
Adds a query to scan a storage domain for disk images not
currently recognized by oVirt. This is done
Ohad Basan has posted comments on this change.
Change subject: tools: Make collect default (BZ856005)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8040
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: cleanup: remove unused isDBUp, execSqlCommand
..
Patch Set 1:
Unless I am missing something...
--
To view, visit http://gerrit.ovirt.org/8108
To unsub
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: cleanup: remove unused isDBUp, execSqlCommand
..
packaging: cleanup: remove unused isDBUp, execSqlCommand
Change-Id: I8276e7a22c1d6e486d16ef9ae516cc56
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 3: Fails
Addressed some of Yair's comments, answered where I disagreed.
NOTE: This is WIP patch. Pleas
Allon Mureinik has uploaded a new change for review.
Change subject: core: TargetDomainImageGroupVDSCommandParamers
..
core: TargetDomainImageGroupVDSCommandParamers
Extracted the TargetDomainImageGroupVDSCommandParamers from th
Sharad Mishra has uploaded a new change for review.
Change subject: core: Refactor getDiskDAO to getDiskDao
..
core: Refactor getDiskDAO to getDiskDao
To fix FindBugs issue -
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2
Allon Mureinik has uploaded a new change for review.
Change subject: core: Introducing SyncImageGroupVDSCommand
..
core: Introducing SyncImageGroupVDSCommand
Added the engine representation of the syncImage SPM command.
This pat
Allon Mureinik has uploaded a new change for review.
Change subject: core: [WIP]: Live Storage Migration commands
..
core: [WIP]: Live Storage Migration commands
WIP of the Live Storage Migration feature.
Currently, this patch c
Allon Mureinik has uploaded a new change for review.
Change subject: core: [WIP] Adding VDSM API for LiveStorageMigration
..
core: [WIP] Adding VDSM API for LiveStorageMigration
Added the VDSM interface calls required for implem
Allon Mureinik has uploaded a new change for review.
Change subject: core: Extracted VmValidator
..
core: Extracted VmValidator
Extracted several VM validation utils from
CreateAllSnapshotsFromVmCommand to a VmValidator class (s
Michael Pasternak has uploaded a new change for review.
Change subject: cli: remove history /connect entry even in case of unsuccessful
connection
..
cli: remove history /connect entry even in case of unsuccessful connection
Ch
Sharad Mishra has posted comments on this change.
Change subject: core: Cleanup method names II
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Sharad Mishra has posted comments on this change.
Change subject: core: Cleanup method names II
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main/
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Import gluster cluster
..
Patch Set 12: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/7261
To unsubscribe, visit http://gerri
Alex Lourie has posted comments on this change.
Change subject: tools: Don't print help on error (BZ858968)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8090
To unsub
Alex Lourie has posted comments on this change.
Change subject: tools: Fix default port (BZ857480)
..
Patch Set 3: (1 inline comment)
File src/engine-iso-uploader.py
Line 785
Alex Lourie has posted comments on this change.
Change subject: tools: Fix default port (BZ857481)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8006
To unsubscribe, v
Alex Lourie has posted comments on this change.
Change subject: tools: Fix default port (BZ857128)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8005
To unsubscribe, v
Alex Lourie has posted comments on this change.
Change subject: tools: Make collect default (BZ856005)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8040
To unsubscrib
Alex Lourie has posted comments on this change.
Change subject: packaging: replaced Jboss service name with ovirt-engine
..
Patch Set 3: Verified
Update info message for the --unattended option.
--
To view, visit http://gerrit
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 8: (7 inline comments)
Responses to most comments in-line. New patch-set to follow with one comment
inco
Alex Lourie has posted comments on this change.
Change subject: packaging: replaced Jboss service name with ovirt-engine
..
Patch Set 2: (1 inline comment)
File packaging/fed
Federico Simoncelli has uploaded a new change for review.
Change subject: Don't add the cdrom device if iso_path is empty
..
Don't add the cdrom device if iso_path is empty
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=85
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Allow attaching v2 domains for v3 pool (#856166)
..
webadmin: Allow attaching v2 domains for v3 pool (#856166)
https://bugzilla.redhat.com/856166
Al
Juan Hernandez has posted comments on this change.
Change subject: packaging: replaced Jboss service name with ovirt-engine
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Just a minor commen
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: replaced Jboss service name with ovirt-engine
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Alex Lourie has posted comments on this change.
Change subject: packaging: replaced Jboss service name with ovirt-engine
..
Patch Set 2: Verified
Verified by building, setup, cleanup and upgrade.
--
To view, visit http://gerri
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: removing access protocols and acl in create volume
..
restapi: removing access protocols and acl in create volume
AccessProtols and AccessC
Michael Pasternak has posted comments on this change.
Change subject: restapi: removing access protocols and acl in create volume
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/64
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 8: (11 inline comments)
File backend/manager/modules
Keith Robertson has uploaded a new change for review.
Change subject: tools: Don't print help on error (BZ858968)
..
tools: Don't print help on error (BZ858968)
Change-Id: I8698c1c32010d889ebae4ccb99df10c590e39ff5
Signed-off-by:
Michael Pasternak has posted comments on this change.
Change subject: cli: release 3.2.0.4-1
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8089
To unsubscribe, visit http://gerri
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.2.0.4-1
..
cli: release 3.2.0.4-1
Change-Id: I74fe1aec3b73ba98bc3df004ec853987336fe4e7
Signed-off-by: Michael Pasternak
---
M Makefi
Michael Pasternak has posted comments on this change.
Change subject: cli: release 3.2.0.4-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8089
To unsubscribe, visit http://gerri
Michael Pasternak has uploaded a new change for review.
Change subject: cli: release 3.2.0.4-1
..
cli: release 3.2.0.4-1
Change-Id: I74fe1aec3b73ba98bc3df004ec853987336fe4e7
Signed-off-by: Michael Pasternak
---
M Makefile
M ovi
Alex Lourie has uploaded a new change for review.
Change subject: packaging: replaced Jboss service name with ovirt-engine
..
packaging: replaced Jboss service name with ovirt-engine
Change-Id: Ib3239c4c4550ddf32ee81525da7d8f3db
Kanagaraj M has posted comments on this change.
Change subject: engine: Execution messages for Gluster Volume Actions (#856102)
..
Patch Set 3: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/7967
To u
Michael Pasternak has submitted this change and it was merged.
Change subject: spec: add the kitchen build require
..
spec: add the kitchen build require
Signed-off-by: Federico Simoncelli
Change-Id: Ie3a1f086a1f14dc3375a0ba58
Michael Pasternak has posted comments on this change.
Change subject: spec: add the kitchen build require
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8086
To unsubscribe, visit
Michael Pasternak has posted comments on this change.
Change subject: spec: add the kitchen build require
..
Patch Set 2:
thanks Federico.
--
To view, visit http://gerrit.ovirt.org/8086
To unsubscribe, visit http://gerrit.ovir
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 3.2.0.2-1
..
sdk: release 3.2.0.2-1
Change-Id: I917210cdd93323743e3011969c323032daf7
Signed-off-by: Michael Pasternak
---
M Makefi
Michael Pasternak has posted comments on this change.
Change subject: sdk: release 3.2.0.2-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8087
To unsubscribe, visit http://gerri
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: release 3.2.0.2-1
..
sdk: release 3.2.0.2-1
Change-Id: I917210cdd93323743e3011969c323032daf7
Signed-off-by: Michael Pasternak
---
M Makefile
M ovi
Federico Simoncelli has uploaded a new change for review.
Change subject: spec: add the kitchen build require
..
spec: add the kitchen build require
Signed-off-by: Federico Simoncelli
Change-Id: Ie3a1f086a1f14dc3375a0ba583813d1
Doron Fediuck has submitted this change and it was merged.
Change subject: core: allow user to filter by user/group (#739854)
..
core: allow user to filter by user/group (#739854)
Adds a search field that allows the user to sea
Doron Fediuck has posted comments on this change.
Change subject: core: allow user to filter by user/group (#739854)
..
Patch Set 3: Verified; Looks good to me, approved
Rebased patch.
--
To view, visit http://gerrit.ovirt.org
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Get Gluster Servers query
..
engine: Get Gluster Servers query
This query will be invoked from Import Gluster Cluster dialog.
This query acce
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 19: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit htt
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Get Server fingerprint query
..
engine: Get Server fingerprint query
Including following related to the command for Get Server fingerprint
- N
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 18: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 18: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 17: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 17: Looks good to me, approved
Looks good.
Giving +2 - after my comments were Resolved + based on previous +1 by
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 17: Verified
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/setti
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 17: Verified
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 2: (3 inline comments)
File
backend/manager/modul
Muli Salem has abandoned this change.
Change subject: core: Allow Non-Required Networks Not On Host (#858654)
..
Patch Set 6: Abandoned
Different fix approach taken.
--
To view, visit http://gerrit.ovirt.org/7992
To unsubscrib
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 16: (9 inline comments)
Incorporated review comments.
Fil
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests
..
Patch Set 1:
This one removes the time zone from the General sub tab of the VM tab. The
initi
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: Run once: unable to attach floppy disks
(#855579)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7965
To unsubscribe, v
Tomas Jelinek has uploaded a new change for review.
Change subject: engine: Run Once dialog ingores emtpy boot options (#857848)
..
engine: Run Once dialog ingores emtpy boot options (#857848)
https://bugzilla.redhat.com/857848
Michael Pasternak has posted comments on this change.
Change subject: cli: release 3.2.0.3-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8082
To unsubscribe, visit http://gerri
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.2.0.3-1
..
cli: release 3.2.0.3-1
Change-Id: I0b91f6c5ce3e5fefe8bf53cf56efc99e760b4c1a
Signed-off-by: Michael Pasternak
---
M Makefi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 16: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://ger
Michael Pasternak has uploaded a new change for review.
Change subject: cli: release 3.2.0.3-1
..
cli: release 3.2.0.3-1
Change-Id: I0b91f6c5ce3e5fefe8bf53cf56efc99e760b4c1a
Signed-off-by: Michael Pasternak
---
M Makefile
M ovi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://ger
Michael Kublin has submitted this change and it was merged.
Change subject: core: Change auto-recovery code for storage domains
..
core: Change auto-recovery code for storage domains
Because of change which was done at error st
Yair Zaslavsky has posted comments on this change.
Change subject: core: Change auto-recovery code for storage domains
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8015
To unsubscribe, vi
Michael Kublin has posted comments on this change.
Change subject: core: Change auto-recovery code for storage domains
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8015
To unsubscribe, visit http://gerrit.
Michael Kublin has submitted this change and it was merged.
Change subject: core: Upgrade status domain
..
core: Upgrade status domain
Because of change in behaviour at error flows, all
statuses of storage domains which were In
Michael Kublin has posted comments on this change.
Change subject: core: Upgrade status domain
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8014
To unsubscribe, visit h
Michael Kublin has submitted this change and it was merged.
Change subject: core: Removed useges of deactivate from error flows at engine
side
..
core: Removed useges of deactivate from error flows at engine side
The following
Michael Kublin has posted comments on this change.
Change subject: core: Removed useges of deactivate from error flows at engine
side
..
Patch Set 7: Verified
Verified by pre-integration team
--
To view, visit http://gerrit.o
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removed useges of deactivate from error flows at engine
side
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7257
To
1 - 100 of 151 matches
Mail list logo
