Keith Robertson has posted comments on this change. Change subject: tools: Fix default port (BZ857128) ......................................................................
Patch Set 2: Verified; Looks good to me, approved (1 inline comment) .................................................... Commit Message Line 4: Commit: Keith Robertson <[email protected]> Line 5: CommitDate: 2012-09-14 10:46:45 -0400 Line 6: Line 7: tools: Fix default port (BZ857128) Line 8: I don't really understand why this is happening. Gerrit is appropriately showing the commit message in the patch as 'Fix default port (BZ857128)'. Yet here it includes information from a previous commit. As a test, I cloned the git repo and cherry picked this patch. In any case, I'm just going to let it ride. User can view the BZ to see the scope of the change. When I do a 'git log' I see... commit 52778f1c8fb2e9bc4880698081e67de5617a0042 Author: Keith Robertson <[email protected]> Date: Fri Sep 14 10:39:05 2012 -0400 tools: Fix default port (BZ857128) Change-Id: I1be2e0c2af8f6c0f05144323686ab84801b2aa45 Signed-off-by: Keith Robertson <[email protected]> Line 9: Change-Id: I1be2e0c2af8f6c0f05144323686ab84801b2aa45 -- To view, visit http://gerrit.ovirt.org/8005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1be2e0c2af8f6c0f05144323686ab84801b2aa45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Keith Robertson <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
