[Engine-patches] Change in ovirt-engine[master]: core: TargetDomainImageGroupVDSCommandParamers

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: core: TargetDomainImageGroupVDSCommandParamers
......................................................................

core: TargetDomainImageGroupVDSCommandParamers

Extracted the TargetDomainImageGroupVDSCommandParamers from the
MoveImageGroupVDSCommandParameters to serve as a general parameter class
for all the VDS commands that need to negotiate an image between two
storage domains.

Currently, MoveImageGroup is the only command using it, but subsequent
patches will introduce further operations.

Change-Id: I9c0c8872e172182248bf337474ebc0e56a473a6c
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java
A 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/TargetDomainImageGroupVDSCommandParamers.java
2 files changed, 37 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/8103/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java
index 36d1861..85884cb 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java
@@ -1,19 +1,9 @@
 package org.ovirt.engine.core.common.vdscommands;
 
-import org.ovirt.engine.core.compat.*;
-import org.ovirt.engine.core.common.businessentities.*;
+import org.ovirt.engine.core.common.businessentities.ImageOperation;
+import org.ovirt.engine.core.compat.Guid;
 
-public class MoveImageGroupVDSCommandParameters extends 
StoragePoolDomainAndGroupIdBaseVDSCommandParameters {
-    private Guid privateDstDomainId = new Guid();
-
-    public Guid getDstDomainId() {
-        return privateDstDomainId;
-    }
-
-    private void setDstDomainId(Guid value) {
-        privateDstDomainId = value;
-    }
-
+public class MoveImageGroupVDSCommandParameters extends 
TargetDomainImageGroupVDSCommandParamers {
     private Guid privateVmId = new Guid();
 
     public Guid getVmId() {
@@ -37,8 +27,7 @@
     public MoveImageGroupVDSCommandParameters(Guid storagePoolId, Guid 
storageDomainId, Guid imageGroupId,
             Guid dstStorageDomainId, Guid vmId, ImageOperation op, boolean 
postZero, boolean force,
             String compatibilityVersion) {
-        super(storagePoolId, storageDomainId, imageGroupId);
-        setDstDomainId(dstStorageDomainId);
+        super(storagePoolId, storageDomainId, imageGroupId, 
dstStorageDomainId);
         setVmId(vmId);
         setOp(op);
         setPostZero(postZero);
@@ -71,9 +60,8 @@
 
     @Override
     public String toString() {
-        return String.format("%s, dstDomainId = %s, vmId = %s, op = %s, 
postZero = %s, force = %s",
+        return String.format("%s, vmId = %s, op = %s, postZero = %s, force = 
%s",
                 super.toString(),
-                getDstDomainId(),
                 getVmId(),
                 getOp(),
                 getPostZero(),
diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/TargetDomainImageGroupVDSCommandParamers.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/TargetDomainImageGroupVDSCommandParamers.java
new file mode 100644
index 0000000..568187f
--- /dev/null
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/TargetDomainImageGroupVDSCommandParamers.java
@@ -0,0 +1,32 @@
+package org.ovirt.engine.core.common.vdscommands;
+
+import org.ovirt.engine.core.compat.Guid;
+
+public class TargetDomainImageGroupVDSCommandParamers extends 
StoragePoolDomainAndGroupIdBaseVDSCommandParameters {
+
+    private Guid privateDstDomainId = new Guid();
+
+    public TargetDomainImageGroupVDSCommandParamers(Guid storagePoolId,
+            Guid storageDomainId,
+            Guid imageGroupId,
+            Guid dstStorageDomainId) {
+        super(storagePoolId, storageDomainId, imageGroupId);
+        setDstDomainId(dstStorageDomainId);
+    }
+
+    public TargetDomainImageGroupVDSCommandParamers() {
+    }
+
+    public Guid getDstDomainId() {
+        return privateDstDomainId;
+    }
+
+    protected void setDstDomainId(Guid value) {
+        privateDstDomainId = value;
+    }
+
+    @Override
+    public String toString() {
+        return String.format("%s, dstDomainId = %s", super.toString(), 
getDstDomainId());
+    }
+}
\ No newline at end of file


--
To view, visit http://gerrit.ovirt.org/8103
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c0c8872e172182248bf337474ebc0e56a473a6c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches