Sharad Mishra has posted comments on this change. Change subject: core: Cleanup method names II ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java Line 72: List<VmNetworkInterface> vmInterfaces = getVmNetworkInterfaceDAO().getAllForVm(getVmId()); Line 73: List<Disk> allVmDisks = new ArrayList<Disk>(getVm().getDiskMap().values()); Line 74: allVmDisks.add(diskInfo); Line 75: Line 76: return checkPciAndIDeLimit(getVm().getnum_of_monitors(), Done Line 77: vmInterfaces, Line 78: allVmDisks, Line 79: getReturnValue().getCanDoActionMessages()); Line 80: } -- To view, visit http://gerrit.ovirt.org/8073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2d9d28a87a83867aef703bd62ac454f78ddadac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
