ofri masad has posted comments on this change.
Change subject: webadmin: Cleanup quota popup view (#847950)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7382
To unsubscribe, visit http://gerrit.ovirt.org/s
ofri masad has posted comments on this change.
Change subject: core: Fix calculation of specific quota (#838589)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7368
To unsubscribe, visit http://gerrit.ovirt.
ofri masad has posted comments on this change.
Change subject: core: Fix calculations of snapshot quota (#848028)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7338
To unsubscribe, visit http://gerrit.ovirt
ofri masad has posted comments on this change.
Change subject: core: Cleanup and text fix (#838589)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mark Wu has abandoned this change.
Change subject: Rename VM channel device name
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/3447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTyp
Mark Wu has abandoned this change.
Change subject: vds_installer.py: change to always download deployUtils.py
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/5300
To unsubscribe, visit http://gerrit.ovirt.or
Moti Asayag has posted comments on this change.
Change subject: core: Introduce ChangeQuotaCommand - disks (#848310)
..
Patch Set 2: (2 inline comments)
I strongly suggest you refer Omer's comment regarding overriding
setActio
Roy Golan has posted comments on this change.
Change subject: core: Add engine-java-launcher script
..
Patch Set 5:
rebase?
--
To view, visit http://gerrit.ovirt.org/5129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has posted comments on this change.
Change subject: core: fixing imports.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7225
To unsubscribe, visit http://gerrit.ovirt.org/setting
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix notifier parameters
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/527/ : FAILURE
http://jenkins.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add local configuration helper
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/526/ : FAILURE
http://jenkins
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: Move defaults out of service script
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/524/ : FAILURE
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddStorageServerConnectionCommand.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddSANStorageDomainCommand.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webamin: Assign Quota for Disk (#848310)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/520/ : FAILURE
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Introduce ChangeQuotaCommand - disks (#848310)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/521/ : FAILURE
Daniel Erez has posted comments on this change.
Change subject: core: Add lock to a disk in attach to VM command (#834888)
..
Patch Set 1: (1 inline comment)
File
backend/ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Cleanup quota popup view (#847950)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/516/ : FAILURE
http:/
Moti Asayag has posted comments on this change.
Change subject: core: Add network filter config value (#809814)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7355
To unsubscribe, visit http://gerrit.ovirt.o
Moti Asayag has posted comments on this change.
Change subject: core: Add Network Filtering rules to VMs (#809814)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7356
To unsubscribe, visit http://gerrit.ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add network filter config value (#809814)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/513/ : FAILURE
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add Network Filtering rules to VMs (#809814)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/514/ : FAILURE
Allon Mureinik has posted comments on this change.
Change subject: core: Introduce ChangeQuotaCommand - disks (#848310)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#849542 bootstrap: acquire time for host immediately before
send
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin,userportal: hourglass in login (#849537)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/507/ : FAILURE
h
Juan Hernandez has posted comments on this change.
Change subject: core: Fix notifier parameters
..
Patch Set 4:
Rebased.
--
To view, visit http://gerrit.ovirt.org/7187
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Juan Hernandez has posted comments on this change.
Change subject: core: Add local configuration helper
..
Patch Set 8:
Re-added the methods to build URLs.
--
To view, visit http://gerrit.ovirt.org/6673
To unsubscribe, visit h
Juan Hernandez has posted comments on this change.
Change subject: core: Add local configuration helper
..
Patch Set 7:
No more default parameters in the python or Java code now, all come from
/usr/share/ovirt-engine/conf/engi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: UI: change Make-Template to more readable text (#848104)
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/503/ : FAI
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddStorageServerConnectionCommand.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7386
To unsubscrib
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Move defaults out of service script
..
packaging: Move defaults out of service script
We used to have the defaults values for local engine configura
Sharad Mishra has abandoned this change.
Change subject: core: Remove deprecated StringHelper in
AddStorageServerConnectionCommand.
..
Patch Set 1: Abandoned
new patch submitted - http://gerrit.ovirt.org/#/c/7386
--
To view,
Sharad Mishra has uploaded a new change for review.
Change subject: core: Remove deprecated StringHelper in
AddStorageServerConnectionCommand.
..
core: Remove deprecated StringHelper in AddStorageServerConnectionCommand.
Replac
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: making gluster enums lower case in request/response
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/489/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Gluster server peer list command
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/488/ : FAILURE
http://jen
Sharad Mishra has posted comments on this change.
Change subject: core: Cleanup and text fix (#838589)
..
Patch Set 1: Looks good to me, but someone else must approve
I personally prefer to keep unrelated changes in separate pa
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddSANStorageDomainCommand.
..
Patch Set 1: (1 inline comment)
File
Sharad Mishra has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 5:
Tested with 6.1.0.42. It should work with all 6.1+ versions.
--
To view, visit http://gerri
Gilad Chaplik has posted comments on this change.
Change subject: core: Introduce ChangeQuotaCommand - disks (#848310)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7357
To unsubscribe, visit http://gerrit.
Gilad Chaplik has posted comments on this change.
Change subject: core: Introduce ChangeQuotaCommand - disks (#848310)
..
Patch Set 2:
as discussed with Allon, added a test to dao to check that the stored proc
works. there no
Gilad Chaplik has posted comments on this change.
Change subject: core: Introduce Change quota command - disks (#848310)
..
Patch Set 1: (3 inline comments)
File
backend/man
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix calculation of specific quota (#838589)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/487/ : FAILURE
h
Omer Frenkel has posted comments on this change.
Change subject: core: Introduce Change quota command - disks (#848310)
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
you cannot add new commands
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: add ENGINE_FQDN variable to service configuration
..
packaging: add ENGINE_FQDN variable to service configuration
The engine FQDN is require
Juan Hernandez has posted comments on this change.
Change subject: packaging: add ENGINE_FQDN variable to service configuration
..
Patch Set 3: Verified; Looks good to me, approved
Based on previous acks.
--
To view, visit htt
Juan Hernandez has posted comments on this change.
Change subject: packaging: add ENGINE_FQDN variable to service configuration
..
Patch Set 2: Verified; Looks good to me, approved
Only cosmetic changes in the last patch set, s
Doron Fediuck has posted comments on this change.
Change subject: core: Fix calculation of specific quota (#838589)
..
Patch Set 1:
Please verify that this will not cause a regression on global
quotas. ie- what happens if we ha
Doron Fediuck has posted comments on this change.
Change subject: core: Cleanup and text fix (#838589)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7365
To unsubscribe, visit http://gerri
Juan Hernandez has posted comments on this change.
Change subject: packaging: add ENGINE_FQDN variable to service configuration
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
...
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add ENGINE_FQDN variable to service configuration
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7384
To unsubscribe, visit http://
Yaniv Dary has posted comments on this change.
Change subject: packaging: add ENGINE_FQDN variable to service configuration
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: add ENGINE_FQDN variable to service configuration
..
packaging: add ENGINE_FQDN variable to service configuration
The engine FQDN is required for depe
Yaniv Dary has posted comments on this change.
Change subject: packaging: changed built jar version to hard coded values
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7379
To uns
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: changed built jar version to hard coded values
..
packaging: changed built jar version to hard coded values
Change-Id: Iabd56405617f9e67a1819e46
Yaniv Dary has posted comments on this change.
Change subject: packaging: changed built jar version to hard coded values
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7379
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: changed built jar version to hard coded values
..
Patch Set 1: (1 inline comment)
You need to touch only the version of the artifact, single location.
Yaniv Dary has posted comments on this change.
Change subject: packaging: use place holders for version/release
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7371
To unsubscribe, visit htt
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: use place holders for version/release
..
packaging: use place holders for version/release
Currently Makefile substitutes complete lines within s
Yaniv Dary has posted comments on this change.
Change subject: packaging: changed built jar version to hard coded values
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/481/ : FAILURE
http://jenkins
Gilad Chaplik has posted comments on this change.
Change subject: core: Introduce Change quota command - disks (#848310)
..
Patch Set 1: (9 inline comments)
File
backend/man
Juan Hernandez has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in RunVmCommandBase.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Juan Hernandez has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
GetAllChildVlanInterfacesQuery.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http:
Juan Hernandez has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in DbUserCacheManager.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Juan Hernandez has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in UpdateVmTemplateCommand.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Juan Hernandez has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
EventSubscriptionCommandBase.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: removing access protocols and acl in create volume
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/475/ :
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: fixing NPE in Reports (#849623)
..
webadmin: fixing NPE in Reports (#849623)
https://bugzilla.redhat.com/849623
There was a change in behavior
Alona Kaplan has posted comments on this change.
Change subject: webadmin: fixing NPE in Reports (#849623)
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/7344
To unsubscr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Cleanup and text fix (#838589)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/472/ : FAILURE
http://jenkins
Juan Hernandez has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
GetVdsInterfacesByVdsIdQuery.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://
Shahar Havivi has submitted this change and it was merged.
Change subject: Webadmin: Tree pane is not refreshed (#845813)
..
Webadmin: Tree pane is not refreshed (#845813)
https://bugzilla.redhat.com/show_bug.cgi?id=845813
Sig
Shahar Havivi has posted comments on this change.
Change subject: Webadmin: Tree pane is not refreshed (#845813)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7374
To unsubscribe
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in RunVmCommandBase.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7278
To unsubscribe, visit http://ge
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
GetAllChildVlanInterfacesQuery.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7277
To unsubscribe,
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in DbUserCacheManager.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7276
To unsubscribe, visit http://
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
GetVdsInterfacesByVdsIdQuery.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7275
To unsubscribe, vi
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in UpdateVmTemplateCommand.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7272
To unsubscribe, visit ht
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
EventSubscriptionCommandBase.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7271
To unsubscribe, vi
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in InstallerMessages.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7270
To unsubscribe, visit http://g
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddExistingSANStorageDomainCommand.
..
Patch Set 1: (2 inline comments)
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddExistingSANStorageDomainCommand.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7239
To unsubscri
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: hourglass in login (#849537)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7376
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Import gluster cluster
..
Patch Set 5: I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.info/job/patch_engine_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: replace Date with long for time variable
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/467/ : SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/468/ : FAILURE
http://jenk
ofri masad has uploaded a new change for review.
Change subject: webadmin: Cleanup quota popup view (#847950)
..
webadmin: Cleanup quota popup view (#847950)
Cleanup, number format fix and constants added.
Change-Id: Ib27be9b4c
Juan Hernandez has posted comments on this change.
Change subject: BZ#849542 bootstrap: acquire time for host immediately before
send
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ger
Daniel Erez has posted comments on this change.
Change subject: Webadmin: Tree pane is not refreshed (#845813)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7374
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#849542 bootstrap: acquire time for host immediately before
send
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7381
To unsubscribe, visit
Alon Bar-Lev has uploaded a new change for review.
Change subject: BZ#849542 bootstrap: acquire time for host immediately before
send
..
BZ#849542 bootstrap: acquire time for host immediately before send
Engine uses its own clo
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add local configuration helper
..
Patch Set 6:
Hi,
As for relocate the file - it is indeed needed.
As for the upgrade - usually you don't need to touch co
Yaniv Dary has uploaded a new change for review.
Change subject: packaging: changed built jar version to hard coded values
..
packaging: changed built jar version to hard coded values
Change-Id: Iabd56405617f9e67a1819e463ba344bb
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: hourglass in login (#849537)
..
Patch Set 1: Looks good to me, approved
Looks good, going to verify.
--
To view, visit http://gerrit.ovirt.
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Remove /usr/share/ovirt-engine/conf/jboss-log4j.xml
..
packaging: Remove /usr/share/ovirt-engine/conf/jboss-log4j.xml
This was used with JBo
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove /usr/share/ovirt-engine/conf/jboss-log4j.xml
..
Patch Set 2: Verified; Looks good to me, approved
Based on previous acks.
--
To view, visit h
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove /usr/share/ovirt-engine/conf/jboss-log4j.xml
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7373
To unsu
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.1.0.8-1
..
cli: release 3.1.0.8-1
Change-Id: I340b023d0a76afee87984ac89b0397fe43b1b3a5
Signed-off-by: Michael Pasternak
---
M Makefi
Michael Pasternak has posted comments on this change.
Change subject: cli: release 3.1.0.8-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7378
To unsubscribe, visit http://gerri
Michael Pasternak has posted comments on this change.
Change subject: sdk: release 3.1.0.6-1
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7377
To unsubscribe, visit http://gerri
1 - 100 of 225 matches
Mail list logo