Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddExistingSANStorageDomainCommand.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java
Line 39:
Line 40: @Override
Line 41: protected boolean
ConcreteCheckExistingStorageDomain(Pair<storage_domain_static, SANState>
domainFromIrs) {
Line 42: boolean returnValue = false;
Line 43: if
(!StringUtils.isEmpty(getStorageDomain().getStorageStaticData().getstorage())
Done
Line 44: &&
!StringUtils.isEmpty(domainFromIrs.getFirst().getstorage())) {
Line 45: returnValue =
Line 46:
(StringUtils.equals(domainFromIrs.getFirst().getstorage(),
getStorageDomain().getStorageStaticData()
Line 47: .getstorage()));
Line 40: @Override
Line 41: protected boolean
ConcreteCheckExistingStorageDomain(Pair<storage_domain_static, SANState>
domainFromIrs) {
Line 42: boolean returnValue = false;
Line 43: if
(!StringUtils.isEmpty(getStorageDomain().getStorageStaticData().getstorage())
Line 44: &&
!StringUtils.isEmpty(domainFromIrs.getFirst().getstorage())) {
Done
Line 45: returnValue =
Line 46:
(StringUtils.equals(domainFromIrs.getFirst().getstorage(),
getStorageDomain().getStorageStaticData()
Line 47: .getstorage()));
Line 48: }
--
To view, visit http://gerrit.ovirt.org/7239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I687dacfb991c59cc5330eea50082c18dd54c96bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
