Sharad Mishra has posted comments on this change.

Change subject: core: Remove deprecated StringHelper in 
AddSANStorageDomainCommand.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
Line 42:         getStorageDomain().setstorage(storage);
Line 43:         if (StringUtils.isEmpty(getStorageDomain().getstorage())) {
Line 44:             getStorageDomain().setstorage(CreateVG());
Line 45:         }
Line 46:         if (!StringUtils.isEmpty(getStorageDomain().getstorage()) && 
(AddStorageDomainInIrs())) {
Done
Line 47:             
DbFacade.getInstance().getStorageDomainStaticDAO().update(getStorageDomain().getStorageStaticData());
Line 48:             UpdateStorageDomainDynamicFromIrs();
Line 49:             ProceedVGLunsInDb();
Line 50:             setSucceeded(true);


--
To view, visit http://gerrit.ovirt.org/7237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e7b8d6e28a72bcfa98ddfa1b5e27b35e98b0a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to