Juan Hernandez has posted comments on this change. Change subject: packaging: add ENGINE_FQDN variable to service configuration ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/fedora/engine-service.sysconfig Line 72: Line 73: # Line 74: # Engine host FQDN Line 75: # Line 76: # ENGINE_FQDN="localhost.localdomain" Can you use "fully qualified domain name" in the comment and end it with ":"? Can you remove the space between the # and the name of the variable? Can you remove the quotes around the value? All of these are purely aesthetics, to be consistent with the rest of the file, feel free to ignore. Line 77: Line 78: # Line 79: # Ports used by the web server (the proxy) and by the connectors Line 80: # of the application server: -- To view, visit http://gerrit.ovirt.org/7384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc2a12280813bc7462ba62bf9e9a7b5358811147 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
