Kiril Nesenko has posted comments on this change.
Change subject: engine: engine-setup to accept DB password with an embedded
space.
..
Patch Set 1: I would prefer that you didn't submit this
I think we should solve this issue
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Do not allow whitespaces in passwords (#BZ835363)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://g
Kiril Nesenko has uploaded a new change for review.
Change subject: packaging: Do not allow whitespaces in passwords (#BZ835363)
..
packaging: Do not allow whitespaces in passwords (#BZ835363)
https://bugzilla.redhat.com/show_bu
Asaf Shakarchi has posted comments on this change.
Change subject: ui: User portal - Disk creator on storage domain cannot create
disks (#846300)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Livnat Peer has posted comments on this change.
Change subject: core: Make NetworkOperationsConnectivity configurable (#840746)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7006
To unsubs
Oved Ourfali has uploaded a new change for review.
Change subject: backend: Granting AddPermission to some admin roles (#845026)
..
backend: Granting AddPermission to some admin roles (#845026)
https://bugzilla.redhat.com/845026
Shireesh Anjal has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Looks good to me, on
Oved Ourfali has posted comments on this change.
Change subject: core: use allow viewing children only in disks, templates and
VMs (#846300)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7004
To unsubscrib
Oved Ourfali has posted comments on this change.
Change subject: core: make user-API relevant queries to be user queries
(#846300)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7003
To unsubscribe, visit h
Oved Ourfali has posted comments on this change.
Change subject: core: disk related DB permission changes (#846300)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7002
To unsubscribe, visit http://gerrit.ovi
Oved Ourfali has posted comments on this change.
Change subject: ui: User portal - Disk creator on storage domain cannot create
disks (#846300)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7001
To unsubsc
Oved Ourfali has posted comments on this change.
Change subject: core: Fixing account disabled handling
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7025
To unsubscribe, visit http://gerr
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: remove install wrappers as there is no selection
..
Patch Set 1:
Putting this first so that we can reduce the size of patches that follows.
--
To view,
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: VdsInstaller* methods name compliance
..
Patch Set 14:
Patch moved to more recent location.
--
To view, visit http://gerrit.ovirt.org/6723
To unsubscrib
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh public key entry should contain new line
..
Patch Set 1:
trivial but required to avoid mistakes.
--
To view, visit http://gerrit.ovirt.org/7027
To uns
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 1:
This is a base of transferring the ssh key in similar manner at next patch.
--
To view,
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine
..
Patch Set 4:
Use umask 0077 when transferring tarball - to allow privacy.
Move bootstrap command to configurati
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: new implementation for apache-sshd usage
..
Patch Set 14:
Modified base patches, so that naming cleanup patch and removal of factory will
be base of t
Alon Bar-Lev has uploaded a new change for review.
Change subject: utils: ssh public key entry should contain new line
..
utils: ssh public key entry should contain new line
A complete entry is a single line.
Change-Id: Ifd2020
Alon Bar-Lev has uploaded a new change for review.
Change subject: cleanup: remove install wrappers as there is no selection
..
cleanup: remove install wrappers as there is no selection
In the past there was multiple implementat
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: send firewall rules without creating temp file
..
bootstrap: send firewall rules without creating temp file
With new SSH implementation there is no ne
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fixing account disabled handling
..
core: Fixing account disabled handling
The following patch fix account disabled handling.
It uses the AuditLog in a c
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 2: (8 inline comments)
As for jboss feature...
As long as this setup is pure application ind
Amador Pahim has uploaded a new change for review.
Change subject: engine: engine-setup to accept DB password with an embedded
space.
..
engine: engine-setup to accept DB password with an embedded space.
https://bugzilla.redhat
Ayal Baron has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 8: I would prefer that you didn't submit this
(3 inline comments)
Moran Goldboim has posted comments on this change.
Change subject: packaging: Change error message when using occupied port
(#BZ813688)
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
lease choos
Doron Fediuck has posted comments on this change.
Change subject: core: db function extensions
..
Patch Set 1: (1 inline comment)
Eli,
There's a potential bug there (one you already solved elsewhere).
See inline.
Juan Hernandez has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 2: (11 inline comments)
Using the jboss specific capability to replace properties inside st
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change error message when using occupied port
(#BZ813688)
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit
Ayal Baron has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 2: (4 inline comments)
File
backend/manager/m
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change error message when using ocupied port
(#BZ813688)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
Eli Mesika has uploaded a new change for review.
Change subject: core: db function extensions
..
core: db function extensions
Adding a new function that accepts the option_name and value and return
back the option_value.
This f
Eli Mesika has uploaded a new change for review.
Change subject: core:encrypt vds_static pm_password field on upgrade to 3.1
..
core:encrypt vds_static pm_password field on upgrade to 3.1
In 3.0 all host having PM configured add
Oved Ourfali has posted comments on this change.
Change subject: WIP - don't submit core: disk related DB permission changes
(#846300)
..
Patch Set 1: (4 inline comments)
Fi
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: making Volumes tab visible in system level
..
webadmin: making Volumes tab visible in system level
Volumes tab will be visible in system level when
the
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed missing refrence to locale bundle.
..
reports: fixed missing refrence to locale bundle.
Also removed unused reports that were duplicated.
C
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed missing refrence to locale bundle.
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7019
To unsubscribe
Yaniv Dary has uploaded a new change for review.
Change subject: reports: fixed missing refrence to locale bundle.
..
reports: fixed missing refrence to locale bundle.
Also removed unused reports that were duplicated.
Change-Id
Sharad Mishra has posted comments on this change.
Change subject: core: Make NetworkOperationsConnectivity configurable (#840746)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: WIP - don't submit core: use allow viewing children only in
disks, templates and VMs (#846300)
..
Patch Set 1: Looks good to me, but someone else must approve
Allon Mureinik has posted comments on this change.
Change subject: WIP - don't submit core: disk related DB permission changes
(#846300)
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
.
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: do not require optional params
..
codegen: do not require optional params
Change-Id: I83cc339b060fd8e68ac0918b5faa827355f48f76
Signed-off-by: Micha
Moti Asayag has uploaded a new change for review.
Change subject: core: Make NetworkOperationsConnectivity configurable (#840746)
..
core: Make NetworkOperationsConnectivity configurable (#840746)
https://bugzilla.redhat.com/840
Yaniv Dary has submitted this change and it was merged.
Change subject: report: updated design of the webadmin dashboards
..
report: updated design of the webadmin dashboards
Change-Id: I22f524c69f8cca42ff5d84b9d8b497d0e5f20ac8
Yaniv Dary has posted comments on this change.
Change subject: report: updated design of the webadmin dashboards
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7005
To unsubscribe
Yaniv Dary has uploaded a new change for review.
Change subject: report: updated design of the webadmin dashboards
..
report: updated design of the webadmin dashboards
Change-Id: I22f524c69f8cca42ff5d84b9d8b497d0e5f20ac8
Signed-
Oved Ourfali has uploaded a new change for review.
Change subject: WIP - don't submit core: use allow viewing children only in
disks, templates and VMs (#846300)
..
WIP - don't submit core: use allow viewing children only in dis
Oved Ourfali has uploaded a new change for review.
Change subject: WIP - don't submit core: make user-API relevant queries to be
user queries (#846300)
..
WIP - don't submit core: make user-API relevant queries to be user querie
Oved Ourfali has uploaded a new change for review.
Change subject: WIP - don't submit core: disk related DB permission changes
(#846300)
..
WIP - don't submit core: disk related DB permission changes (#846300)
https://bugzilla.
Oved Ourfali has uploaded a new change for review.
Change subject: WIP - don't submit ui: User portal - Disk creator on storage
domain cannot create disks (#846300)
..
WIP - don't submit ui: User portal - Disk creator on storage
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: [SetupNetworks] nets behaviour on bond create/extend
(#840825)
..
webadmin: [SetupNetworks] nets behaviour on bond create/extend (#840825)
http
Daniel Erez has posted comments on this change.
Change subject: webadmin: [SetupNetworks] nets behaviour on bond create/extend
(#840825)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/6987
To unsubscribe, v
Daniel Erez has posted comments on this change.
Change subject: webadmin: [SetupNetworks] nets behaviour on bond create/extend
(#840825)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6987
Kiril Nesenko has uploaded a new change for review.
Change subject: packaging: Change error message when using ocupied port
(#BZ813688)
..
packaging: Change error message when using ocupied port (#BZ813688)
https://bugzilla.red
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Fixing vlan capitalization (#821456)
..
Patch Set 2:
1. According to the first screenshot in the BZ the "vlan" capitalization in the
SetupNetworks is a
Ayal Baron has posted comments on this change.
Change subject: core: added information to ConnectStorageVDScommand logs
(#835546)
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 9:
set ssh key alias to be ovirt-engine as this what bootstrap expects.
--
To view, visit http://gerrit
Omer Frenkel has posted comments on this change.
Change subject: core: keep the current VM status after failing migration
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6998
To unsubscribe,
Roy Golan has uploaded a new change for review.
Change subject: core: failure migrating a VM keeps the current VM status
..
core: failure migrating a VM keeps the current VM status
There is no good reason for marking a VM nonRes
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Edit job message referencing template/VM(#818295)
..
core:Edit job message referencing template/VM(#818295)
https://bugzilla.redhat.com/show_bug.cgi
Maor Lipchuk has posted comments on this change.
Change subject: core:Edit job message referencing template/VM(#818295)
..
Patch Set 7: Verified; Looks good to me, approved
Acked by derez
--
To view, visit http://gerrit.ovirt.
Ohad Basan has posted comments on this change.
Change subject: tools: Add tolerance to engine-setup min memory threshold
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Shireesh Anjal has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 1:
It will be good if there is another variant of getServerKeyFingerprint that
takes only
Ofer Schreiber has submitted this change and it was merged.
Change subject: tools: Add tolerance to engine-setup min memory threshold
..
tools: Add tolerance to engine-setup min memory threshold
engine-setup exits with error if
Ofer Schreiber has posted comments on this change.
Change subject: tools: Add tolerance to engine-setup min memory threshold
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6992
To
Ofer Schreiber has posted comments on this change.
Change subject: tools: Add tolerance to engine-setup min memory threshold
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6992
To unsubscri
Eli Mesika has abandoned this change.
Change subject: core: adding a db function to get a config value
..
Patch Set 1: Abandoned
Will be pushed as a part of BZ 757642 fix.
--
To view, visit http://gerrit.ovirt.org/6981
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 8:
ofrenkel - forgot to press "review", my bad.
see inline.
--
To view, visit http://gerrit.ovirt.org/6676
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 7: (3 inline comments)
File
backend/manager/modules/b
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 1:
I put this in Mina so I will be able to clean it up in future.
encryptutils package shoul
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: new implementation for apache-sshd usage
..
Patch Set 13:
Minor cleanups for tests.
--
To view, visit http://gerrit.ovirt.org/6722
To unsubscribe, vis
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
bootstrap: allow retrieve ssh key fingerprint of server
Required for future user validation.
Change-I
Selvasundaram has abandoned this change.
Change subject: engine: Gluster - Backend: Bad CanDoAction error on moving host
with volumes to another cluster - fixed
..
Patch Set 2: Abandoned
Fix already merged with the patch: http
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
..
Patch Set 8: (1 inline comment)
maybe we can add a method called getVm(boolean cache) which wil
Asaf Shakarchi has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 2: Looks good to me, but someone else must approve
Ack on the web apps side,
Some of the c
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Brick existance validation for add brick
..
engine: Brick existance validation for add brick
- New brick exists check is added in Add Brick T
Omer Frenkel has posted comments on this change.
Change subject: engine: Brick existance validation for add brick
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5432
To unsubscribe, visit h
Selvasundaram has posted comments on this change.
Change subject: engine: Brick existance validation for add brick
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/5432
To unsubscribe, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVmCommand - changed method UpdateVmImSpm() name
..
Patch Set 8: Looks good to me, approved
Consider also changing VmCommand.UpdateVmInSpm in another p
Maor Lipchuk has posted comments on this change.
Change subject: core: fix removal of lun disk with no vm (#841265)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6566
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has posted comments on this change.
Change subject: core: fix removal of lun disk with no vm (#841265)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6566
To unsubscribe, visit
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: fix NPE in new cluster dialogue
..
UI: fix NPE in new cluster dialogue
Change-Id: Ic5de999ab1a18e7c9c44e5073380da8c41122355
Signed-off-by: Shahar Ha
Shahar Havivi has posted comments on this change.
Change subject: UI: fix NPE in new cluster dialogue
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6982
To unsubscribe, visit htt
Daniel Erez has posted comments on this change.
Change subject: UI: fix NPE in new cluster dialogue
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6982
To unsubscribe, visit http://gerrit.o
Doron Fediuck has submitted this change and it was merged.
Change subject: backend: Quota log messages with UNKNOWN (#844646)
..
backend: Quota log messages with UNKNOWN (#844646)
https://bugzilla.redhat.com/844646
creating, r
Doron Fediuck has posted comments on this change.
Change subject: backend: Quota log messages with UNKNOWN (#844646)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6896
To unsubsc
Doron Fediuck has posted comments on this change.
Change subject: backend: Quota log messages with UNKNOWN (#844646)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6896
To unsubscribe, visi
Omer Frenkel has posted comments on this change.
Change subject: engine: Brick existance validation for add brick
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5432
To unsubscribe, visit h
Omer Frenkel has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 8:
any response to my comment in restore?
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, vis
Maor Lipchuk has posted comments on this change.
Change subject: core:Use %d instead %i for String format (#843099)
..
Patch Set 2: Verified; Looks good to me, approved
Acked by mkublin
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Use %d instead %i for String format (#843099)
..
core:Use %d instead %i for String format (#843099)
Fix UnknownFormatConversionException by changing
Michael Pasternak has posted comments on this change.
Change subject: restapi: Fix Response Body For Setup-Networks
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
...
Maor Lipchuk has posted comments on this change.
Change subject: core:Use %d instead %i for String format (#843099)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6986
To unsubscribe, visit http://gerrit.ovi
93 matches
Mail list logo
