Alon Bar-Lev has uploaded a new change for review. Change subject: cleanup: remove install wrappers as there is no selection ......................................................................
cleanup: remove install wrappers as there is no selection In the past there was multiple implementations for CA and SSH usage. Long time that the OpenSSL and apache sshd are the only options. The extra abstraction makes code maintenance complex without any apparent need. This change removes this abstraction level in favour of direct usage. It also rename the 'Mina' to something more meaningful. REMOVED ICAWrapper IVdsInstallWrapper VdsInstallerFactory RENAMED IVdsInstallCallBack->IVdsInstallerCallback MinaInstallWrapper->VdsInstallerSSH Change-Id: I9522964674ead688500002f7d581171a5e3a3712 Signed-off-by: Alon Bar-Lev <alo...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/ICAWrapper.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IVdsInstallWrapper.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IVdsInstallerCallback.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerFactory.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTimeoutTest.java 10 files changed, 27 insertions(+), 67 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/7026/1 -- To view, visit http://gerrit.ovirt.org/7026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9522964674ead688500002f7d581171a5e3a3712 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches