Alon Bar-Lev has posted comments on this change. Change subject: packaging: redirect to TLS/SSL using application server ......................................................................
Patch Set 2: (8 inline comments) As for jboss feature... As long as this setup is pure application independent configuration, there is no impact of using the jboss feature if it makes lives easier. .................................................... File backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml Line 15: <!-- TLS/SSL settings --> Done Line 19: <description>Protected Context</description> Done .................................................... File backend/manager/modules/root/src/main/webapp/index.html Line 50: <div><a href="OvirtEngineWeb/RedirectServlet?Page=Reports">Reports Portal</a></div> Web application should be relative to its own root. If we move jboss proxy to /ovirt it should continue to work. Can you please explain again the 404 issue, I don't understand. .................................................... File packaging/fedora/engine-service.py Line 382: engineArgs.append("-DOVIRT_APPS_TRANSPORT_GUARANTEE=CONFIDENTIAL") I think this "engine" is a very bad prefix. Our product is ovirt. Downstream will align. .................................................... File packaging/fedora/engine-service.sysconfig Line 68: #ENGINE_APPS_FORCE_SECURE=true Done .................................................... File packaging/fedora/setup/basedefs.py Line 64 ofer took care of this. .................................................... File packaging/fedora/setup/common_utils.py Line 892 was copied to downstream. .................................................... File packaging/fedora/spec/ovirt-engine.spec.in Line 364: done Done. Although, I don't understand why tabs are evil in RHEV group... -- To view, visit http://gerrit.ovirt.org/6827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0d05ce7224548123c9f5f2a1ce09bf090625085 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches