Ayal Baron has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
Line 154: StorageDomainType storageDomainType =
getStorageDomain().getstorage_domain_type();
would be clearer if this said storageDomainFunction (it serves as a data
domain, it is of type fcp)
Line 170: }
why not the following?
if (storagePool == null) {
storagePool = getStoragePoolDAO().get(getVds().getstorage_pool_id());
if (storagePool == null) {
return false;
}
}
supportedStorageFormats =
getSupportedStorageFormatSet(storagePool.getcompatibility_version());
(note that after removing V1 limitation below, storagePool will never be used
beyond this scope).
Also, I think it would be clearer if it were named targetStoragePool
This can also be in a separate doesDCSupportStorageFormat method (name
improvements welcome)
Line 172: // Verify that the specified storage format is supported
I think the 'if' is self explanatory
Line 176:
isBlockStorage and isDataStorageDomain are only used from here so I think they
should be defined here and possibly also this section should be in a
isSupportedStorageFormat method
--
To view, visit http://gerrit.ovirt.org/6990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia062c1587bc6c35c7ec27270d450d1e312742086
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
