Daniel Erez has uploaded a new change for review.
Change subject: webadmin: missing localized Attach-Detach Disk enum
..
webadmin: missing localized Attach-Detach Disk enum
Added missing localization for 'AttachDiskToVm' and
'De
Oved Ourfali has posted comments on this change.
Change subject: core: cleanup in VmInfoBuilderBase
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5063
To unsubscribe, visit http:
Oved Ourfali has posted comments on this change.
Change subject: core: cleanup in VmInfoBuilderBase
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5063
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Rename ITDSDSGroupAttributes.java to
ITDSGroupAttributes.java
..
Patch Set 1:
Sharad, please verify this (and mark as verified).
After that fetch/rebas
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Rename ITDSDSGroupAttributes.java to
ITDSGroupAttributes.java
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5080
Doron Fediuck has submitted this change and it was merged.
Change subject: core: add memory balloon device support
..
core: add memory balloon device support
This is the core patch that add support of a Memory Balloon
device as
Doron Fediuck has posted comments on this change.
Change subject: core: add memory balloon device support
..
Patch Set 10: Verified; Looks good to me, approved
Rebased patch.
--
To view, visit http://gerrit.ovirt.org/4993
To u
Doron Fediuck has posted comments on this change.
Change subject: core: add memory balloon device support
..
Patch Set 9: Verified; Looks good to me, approved
Omer: we have editable fields, which may be changed while vm is runn
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Missing gateway field when creating bond (#815415)
..
webadmin: Missing gateway field when creating bond (#815415)
https://bugzilla.redhat.com/8
Moti Asayag has posted comments on this change.
Change subject: webadmin: Missing gateway field when creating bond (#815415)
..
Patch Set 3: Verified; Looks good to me, approved
Verified with vdsm-4.9-112.12.el6_2.x86_64
--
To
Moti Asayag has uploaded a new change for review.
Change subject: core: Failed to activate host on 3.0 cluster (#828970)
..
core: Failed to activate host on 3.0 cluster (#828970)
https://bugzilla.redhat.com/828970
Bridge-less f
Itamar Heim has posted comments on this change.
Change subject: engine: Alphanumeric sorting order for db query results (no bz)
..
Patch Set 1:
looks simple enough, but...
I think it is actually an issue fixing this if the loca
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Rename ITDSDSGroupAttributes.java to
ITDSGroupAttributes.java
..
engine: Rename ITDSDSGroupAttributes.java to ITDSGroupAttributes.java
There was a typo
Rami Vaknin has uploaded a new change for review.
Change subject: engine: Alphanumeric sorting order for db query results (no bz)
..
engine: Alphanumeric sorting order for db query results (no bz)
Database queries are not sorted
Itamar Heim has posted comments on this change.
Change subject: userportal: spice client properties
..
Patch Set 2:
does it rely on spice guest agent installed in guest (you can check for that if
not already checking)
--
To v
Itamar Heim has posted comments on this change.
Change subject: core: Fixing timeo to proper time units
..
Patch Set 1:
why are we changing the units from what people expect of mount?
--
To view, visit http://gerrit.ovirt.org/
Ayal Baron has posted comments on this change.
Change subject: webadmin: Fix error notice when adding iSCSI storage <10GB
(#819330)
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Gilad Chaplik has uploaded a new change for review.
Change subject: core: fix import template
..
core: fix import template
Change-Id: I334e9b74366d80a77aec12936218289bc9e1bc25
Signed-off-by: Gilad Chaplik
---
M
backend/manager
Yair Zaslavsky has posted comments on this change.
Change subject: core: add memory balloon device support
..
Patch Set 9:
Reviewed your changes since last patch set. What you did looks good, but I
don't see any addressing to
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing connections psql functions
..
Patch Set 2: Verified
Added storage domain with ver = 3, timeo = 70, retrans=7 and saw that proper
information was s
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing timeo to proper time units
..
Patch Set 1: Verified
Passed 70 at UI for timeo (70 seconds).
when using "mount" on host I saw that the timout value
Keith Robertson has uploaded a new change for review.
Change subject: tools: Collect HTTPD logs (#808882)
..
tools: Collect HTTPD logs (#808882)
https://bugzilla.redhat.com/808882
Collect all HTTPd log and conf files.
Change-I
ShaoHe Feng has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 3:
give up importing generateDS module.
Add the configure file paramsconf.py, it is pytho
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1030/
Build Number: 1030
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,455
-
Changes Since
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fixing timeo to proper time units
..
core: Fixing timeo to proper time units
Tiemout is defined as seconds at UI and API,
but vdsm should work with units
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: ClassCastException when edit a VM
..
userportal: ClassCastException when edit a VM
In user portal extended view:
VM side tab -> select a VM -> press
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated default encryption key size to 2048 (#800397)
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/4389
To unsubscribe, visit http
Alex Lourie has posted comments on this change.
Change subject: packaging: Moving Jboss configuration functions to separate
module
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit htt
Alex Lourie has posted comments on this change.
Change subject: packaging: Moving to use execCmd in all scripts (#731686)
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Tomas Jelinek has uploaded a new change for review.
Change subject: engine: adding WANDisableEffects and WANColorDepth to
vdc_options
..
engine: adding WANDisableEffects and WANColorDepth to vdc_options
Needed by Spice.
Change
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: spice client properties
..
userportal: spice client properties
Added the following properites to the ConsolePopupView
needed by spice:
- WanDisableE
Maor Lipchuk has posted comments on this change.
Change subject: core:Clenup. Remove containerId references
..
Patch Set 2:
Changes from last patch:
1. Regarding Kublin comment, I changed the API of vmTemplates DAO to return
o
Shahar Havivi has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
..
Patch Set 26: (7 inline comments)
File
backend/manager/modules/
Omer Frenkel has posted comments on this change.
Change subject: core: add memory balloon device support
..
Patch Set 8: (1 inline comment)
i think missing a check on update vm to block user from adding/removing balloon
when v
Omer Frenkel has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 11: (5 inline comments)
if you add new fields to lun entity you need to populate it everywhere it is
used, means new v
Alex Lourie has posted comments on this change.
Change subject: packaging: Moving to use execCmd in all scripts (#731686)
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Eli Mesika has posted comments on this change.
Change subject: core: add memory balloon device support
..
Patch Set 8: Verified
1) removed property from VmStatic
2) add a Test class for the query
--
To view, visit http://gerri
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1029/
Build Number: 1029
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,454
-
Changes Sin
Alex Lourie has posted comments on this change.
Change subject: package: Updated sysprep.w7 profiles for Windows 7 (#786394)
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Using DPI set to 96 in syspr
Allon Mureinik has posted comments on this change.
Change subject: core: ObjectIdentityChecker cleanup
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4899
To unsubscrib
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: USB Support
..
webadmin: USB Support
Create/Edit VM dialog -> Console -> USB Support changed
according to:
http://www.ovirt.org/wiki/Features/SPICERel
Roy Golan has submitted this change and it was merged.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
engine: Add support for IBM Tivoli Directory Server.
This patch adds support for an LDAP server from
Roy Golan has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4633
To unsubscri
Roy Golan has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4633
To unsubscri
Oved Ourfali has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4633
To unsubscribe, vis
Oved Ourfali has posted comments on this change.
Change subject: core: cleanup in VmInfoBuilderBase
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/vdsbroker
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1027/
Build Number: 1027
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,452
-
Changes Since
Michael Kublin has submitted this change and it was merged.
Change subject: core : Fixing diskId at MoveOrCopyDiskCommand
..
core : Fixing diskId at MoveOrCopyDiskCommand
We should use a diskId in order to get lock on disk obje
Michael Kublin has posted comments on this change.
Change subject: core : Fixing diskId at MoveOrCopyDiskCommand
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5066
To un
Oved Ourfali has posted comments on this change.
Change subject: core: cleanup in VmInfoBuilderBase
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/vdsbroker
Yair Zaslavsky has posted comments on this change.
Change subject: core : Fixing diskId at MoveOrCopyDiskCommand
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5066
To unsubscribe
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing diskId at MoveOrCopyDiskCommand
..
core : Fixing diskId at MoveOrCopyDiskCommand
We should use a diskId in order to get lock on disk object and n
Roy Golan has submitted this change and it was merged.
Change subject: core: fix the regression fix of fixtures Signed-off-by: Roy
Golan
..
core: fix the regression fix of fixtures
Signed-off-by: Roy Golan
Change-Id: I5dcf55
Asaf Shakarchi has posted comments on this change.
Change subject: core: fix the regression fix of fixtures Signed-off-by: Roy
Golan
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1026/
Build Number: 1026
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,450,
Started by upstream project "ovirt_engine" build
Roy Golan has abandoned this change.
Change subject: core: fix DAO test
..
Patch Set 1: Abandoned
fixed in 5059
--
To view, visit http://gerrit.ovirt.org/5060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mess
Michael Kublin has submitted this change and it was merged.
Change subject: core: fix regression in vm dynamic
..
core: fix regression in vm dynamic
new removed and renamed db columns [last_start_time] is mishandled
Change-Id:
Michael Kublin has posted comments on this change.
Change subject: core: fix regression in vm dynamic
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5059
To unsubscribe, visit htt
Roy Golan has uploaded a new change for review.
Change subject: core: fix DAO test
..
core: fix DAO test
Change-Id: I64faf84a0a4f978c5f14818b4b98ace33809027e
Signed-off-by: Roy Golan
---
M
backend/manager/modules/common/src/ma
Gilad Chaplik has uploaded a new change for review.
Change subject: core: fix regression in vm dynamic
..
core: fix regression in vm dynamic
new removed and renamed db columns [last_start_time] is mishandled
Change-Id: I44e9382
Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, vi
Asaf Shakarchi has submitted this change and it was merged.
Change subject: core: Permission filtering for GetAllVdsGroups.
..
core: Permission filtering for GetAllVdsGroups.
Change-Id: Ic11ced57afb59ab4629c2e29447703cabe580a8c
Asaf Shakarchi has submitted this change and it was merged.
Change subject: restapi: non admin user api - Filtering vms/vm pools (#783087)
..
restapi: non admin user api - Filtering vms/vm pools (#783087)
https://bugzilla.redha
Asaf Shakarchi has posted comments on this change.
Change subject: restapi: non admin user api - Filtering vms/vm pools (#783087)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/50
Asaf Shakarchi has posted comments on this change.
Change subject: core: Permission filtering for GetAllVdsGroups.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5053
To unsubscri
Tal Nisan has posted comments on this change.
Change subject: core: Permission filtering for GetAllVdsGroups.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5053
To unsubscribe, visit http:
Daniel Erez has abandoned this change.
Change subject: core: Define GetDeviceList as User query
..
Patch Set 4: Abandoned
DirectLUN disks via the user portal is not supported
--
To view, visit http://gerrit.ovirt.org/5046
To u
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Fix error notice when adding iSCSI storage <10GB
(#819330)
..
webadmin: Fix error notice when adding iSCSI storage <10GB (#819330)
https://bugzilla.redha
Juan Hernandez has posted comments on this change.
Change subject: core: Increase file servlet size warning threshold to 1 MiB
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4969
To unsubscribe, visit http:/
Itamar Heim has posted comments on this change.
Change subject: core: Define GetDeviceList as User query
..
Patch Set 4: I would prefer that you didn't submit this
please explain why this is needed, the type of devices being re
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: fix regression in Import VM
..
core: fix regression in Import VM
wrong volume type and format in case of import vm more than once
Change-Id: If35
Gilad Chaplik has posted comments on this change.
Change subject: core: fix regression in Import VM
..
Patch Set 2: Verified; Looks good to me, approved
rebased & verified
--
To view, visit http://gerrit.ovirt.org/5030
To unsu
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix use of namespaces in OVF writers
..
core: Fix use of namespaces in OVF writers
Commit 80583b2c4c76f390f87102bf514ec41eca6dd153 introduced some
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix use of namespaces in OVF writers
..
Patch Set 3: Verified; Looks good to me, approved
rebased & verified
--
To view, visit http://gerrit.ovirt.org/504
Maor Lipchuk has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules/bll/src/main/
Livnat Peer has posted comments on this change.
Change subject: core: Add equals&hashcode to NIC entities
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4927
To unsubscribe, visit http://ge
Livnat Peer has posted comments on this change.
Change subject: core: SN: Decouple networks & bonds names from list
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4926
To unsubscribe, visit
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Reducing replica count feature in Remove brick
..
Patch Set 3: (1 inline comment)
File
backend/m
Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: Define GetDeviceList as User query
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5046
To unsub
Mike Kolesnik has posted comments on this change.
Change subject: core: Enable VLAN & no network over bond (#826401)
..
Patch Set 2: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/5056
To unsubscribe, visit http://
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1265/
Build Number: 1265
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,446
-
Ch
Roy Golan has submitted this change and it was merged.
Change subject: core: rename upgrade script
..
core: rename upgrade script
Change-Id: I73fe26116fe4b59dc30e73cac14449068c7e1341
Signed-off-by: Roy Golan
---
R
backend/man
Roy Golan has posted comments on this change.
Change subject: core: rename upgrade script
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5055
To unsubscribe, visit http://gerrit.o
my bad. fixing
On 06/05/2012 11:17 AM, Jenkins oVirt Server wrote:
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1264/
Build Number: 1264
Build Status: Failure
Triggered By: Started by upstream project "ov
Roy Golan has posted comments on this change.
Change subject: core: rename upgrade script
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1264/
Build Number: 1264
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,445
-
Omer Frenkel has posted comments on this change.
Change subject: engine: vds Error handling in gluster vdc commands.
..
Patch Set 2: (1 inline comment)
File
backend/manager
Juan Hernandez has posted comments on this change.
Change subject: core: Fix use of namespaces in OVF writers
..
Patch Set 2:
Rebased.
--
To view, visit http://gerrit.ovirt.org/5040
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: ObjectIdentityChecker cleanup
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4899
To unsubscrib
Omer Frenkel has posted comments on this change.
Change subject: core: rename upgrade script
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5055
To unsubscribe, visit http://gerrit.ovirt.or
Roy Golan has uploaded a new change for review.
Change subject: core: rename upgrade script
..
core: rename upgrade script
Change-Id: I73fe26116fe4b59dc30e73cac14449068c7e1341
Signed-off-by: Roy Golan
---
D
backend/manager/dbs
Roy Golan has submitted this change and it was merged.
Change subject: core: store the create time of a vm under
vm_dynamic.vm_last_boot_time
..
core: store the create time of a vm under vm_dynamic.vm_last_boot_time
whenever a
Roy Golan has posted comments on this change.
Change subject: core: store the create time of a vm under
vm_dynamic.vm_last_boot_time
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.or
Michael Kublin has posted comments on this change.
Change subject: core: fix regression in Import VM
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5030
To unsubscribe, visit http://gerrit.
Michael Kublin has posted comments on this change.
Change subject: core: Fix use of namespaces in OVF writers
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5040
To unsubscribe, visit http:
Michael Pasternak has posted comments on this change.
Change subject: restapi: Grayed-Out LUNs Support
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4859
To unsubscribe, visit ht
Yair Zaslavsky has abandoned this change.
Change subject: webadmin: Filter out versions less than 3.1 for Posix DC
..
Patch Set 2: Abandoned
Already merged upstream
--
To view, visit http://gerrit.ovirt.org/3738
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetAllVdsGroups.
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
see inline.
Also, adding a test
Omer Frenkel has posted comments on this change.
Change subject: engine: canDoAction for No up server found validation added
..
Patch Set 1: Looks good to me, approved
basically i would prefer to refactor getUpServer() to retur
1 - 100 of 120 matches
Mail list logo
