Ayal Baron has posted comments on this change.

Change subject: webadmin: Fix error notice when adding iSCSI storage <10GB 
(#819330)
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 11: When adding an iSCSI storage smaller than 10GB, the error given in
This does not really explain what the issue was.

When new SD creation failed, failure status was not checked and flow continued 
to try and attach the SD to a pool which obviously failed and returned a 
storage domain not found error instead of the creation failure.
SD creation status is now checked before proceeding.

--
To view, visit http://gerrit.ovirt.org/5058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9c0e5aa18d6faf3019569f1b1dae29709406af1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to