Omer Frenkel has posted comments on this change. Change subject: engine: vds Error handling in gluster vdc commands. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java Line 177: fault.setError(VdcBllErrors.GlusterAddHostFailed); why not use the error from returnValue? and use VdcBllErrors.GlusterAddHostFailed only as default -- To view, visit http://gerrit.ovirt.org/4989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec802defb06eb0581b331b4f075356059ef99d24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
