Allon Mureinik has posted comments on this change.
Change subject: core: Permission filtering for GetAllVdsGroups.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
see inline.
Also, adding a test for the query would be great, but up to you.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVdsGroupsQuery.java
Line 12: protected void executeQueryCommand() {
use getDbFacade() isntead of DbFacade.getInstance()
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java
Line 248: @Test
The test name does not match what you're testing.
which one is correct?
Line 265:
Please add a test with UNPRIVILEGED_USER and FALSE - it should return all the
groups.
--
To view, visit http://gerrit.ovirt.org/5053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic11ced57afb59ab4629c2e29447703cabe580a8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
